Add a new gatsby-cli package #1696
Conversation
This reverts commit cf58bb7.
|
Should this be modified too ? https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-dev-cli/README.md |
|
No — this is for everyone to use. It's a replacement for installing the |
|
Deploy preview failed. Built with commit d8e6b6c https://app.netlify.com/sites/using-glamor/deploys/598245bd0752d007b92d1ce1 |
|
Deploy preview failed. Built with commit c7e1e63 https://app.netlify.com/sites/using-glamor/deploys/598249c90752d053f62d1c92 |
| let localPackageJSON | ||
| try { | ||
| localPackageJSON = require(path.resolve(`./package.json`)) | ||
| if (localPackageJSON.dependencies && localPackageJSON.dependencies.gatsby) { |
There was a problem hiding this comment.
@KyleAMathews is there is a reason why devDependencies are not checked? in our setup gatsby is a dev dep, and this change broke our builds 😿 .
There was a problem hiding this comment.
None :-) I just didn't think about that as I've never made gatsby a devDependency but can now there's plenty of use cases where that makes sense. I'll merge #1738 and make a new release.
Once landed, users should install this globally instead of the Gatsby package.