Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check for gatsby in devDependencies. #1738

Merged
merged 2 commits into from
Aug 8, 2017

Conversation

michaek
Copy link
Contributor

@michaek michaek commented Aug 6, 2017

Following from discussion in #832, this adds a check for Gatsby in the current project's devDependencies in addition to dependencies.

@gatsbybot
Copy link
Collaborator

gatsbybot commented Aug 6, 2017

Deploy preview ready!

Built with commit 9f85dd8

https://deploy-preview-1738--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Aug 6, 2017

Deploy preview ready!

Built with commit 9f85dd8

https://deploy-preview-1738--gatsbygram.netlify.com

@KyleAMathews
Copy link
Contributor

Thanks!

@KyleAMathews KyleAMathews merged commit d4683e0 into gatsbyjs:master Aug 8, 2017
@michaek michaek deleted the inGatsbySite-devDependencies branch August 8, 2017 14:24
@systimotic
Copy link

Hi! I came across this PR and have a question about it. The checks added here look like they were already present in the else if statement below. Am I missing something?

@jquense
Copy link
Contributor

jquense commented Aug 24, 2017

yeah it is...weird

@KyleAMathews
Copy link
Contributor

Hmmm yeah that was a mistake.

@jquense I'll assume your cli refactor fixes this? :-)

@jquense
Copy link
Contributor

jquense commented Aug 24, 2017

it does!

@systimotic
Copy link

Sorry for bothering you about this then, thanks for looking at it! Thanks for your work on Gatsby as well, I'm loving it! ❤️

@jlengstorf
Copy link
Contributor

Hiya @michaek! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants