fix(gatsby): Fix various small DEV_SSR bugs exposed in development_runtime tests #29720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e focus wrapper child
gatsbot
bot
added
the
status: triage needed
KyleAMathews
commented
Feb 23, 2021
e2e-tests/development-runtime/cypress/integration/functionality/hooks.js
Outdated
Show resolved
Hide resolved
packages/gatsby/cache-dir/app.js
Outdated
| @@ -126,7 +126,7 @@ apiRunnerAsync(`onClientEntry`).then(() => { | |||
| undefined, | |||
| // Client only pages have any empty body so we just do a normal | |||
| // render to avoid React complaining about hydration mis-matches. | |||
| document.getElementById(`___gatsby`).children.length === 0 | |||
| document.getElementById(`gatsby-focus-wrapper`).children.length === 0 | |||
There was a problem hiding this comment.
___gatsby always has a child so wasn't actually testing if there was SSRed content or not so client-only pages would show a hydration warning.
| @@ -10,13 +10,13 @@ export const route = ({ app, program, store }): any => | |||
| app.get(`*`, async (req, res, next) => { | |||
| trackFeatureIsUsed(`GATSBY_EXPERIMENTAL_DEV_SSR`) | |||
|
|
|||
| const pathObj = findPageByPath(store.getState(), req.path) | |||
| const pathObj = findPageByPath(store.getState(), decodeURI(req.path)) | |||
There was a problem hiding this comment.
Handle paths with unicode characters
| @@ -59,8 +59,13 @@ export const restartWorker = (htmlComponentRendererPath): void => { | |||
|
|
|||
| const searchFileForString = (substring, filePath): Promise<boolean> => | |||
| new Promise(resolve => { | |||
| const escapedSubString = substring.replace(/[.*+?^${}()|[\]\\]/g, `\\$&`) | |||
There was a problem hiding this comment.
Handle paths with special characters
KyleAMathews
added
topic: ssr
and removed
status: triage needed
KyleAMathews
changed the title
KyleAMathews
changed the title
pieh
approved these changes
Mar 1, 2021
vladar
pushed a commit
that referenced
this pull request
Mar 1, 2021
…ntime tests (#29720) * the dev server now returns 404s which would otherwise fail the tests * Correctly detect if there's any SSRed HTML as ___gatsby always has the focus wrapper child * Handle unicode paths like /안녕 * Properly escape paths with special characters in it * Enable DEV_SSR for everyone * Fix status in test * Revert to 20% rollout * revert changes for 100% rollout * test this (cherry picked from commit 114e006)
vladar
pushed a commit
that referenced
this pull request
Mar 1, 2021
…ntime tests (#29720) (#29866) * the dev server now returns 404s which would otherwise fail the tests * Correctly detect if there's any SSRed HTML as ___gatsby always has the focus wrapper child * Handle unicode paths like /안녕 * Properly escape paths with special characters in it * Enable DEV_SSR for everyone * Fix status in test * Revert to 20% rollout * revert changes for 100% rollout * test this (cherry picked from commit 114e006) Co-authored-by: Kyle Mathews <mathews.kyle@gmail.com>
This was referenced Mar 27, 2024
This was referenced Apr 15, 2024
This was referenced May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR includes some misc test fixes to fixes issues in tests.