-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby): Fix various small DEV_SSR bugs exposed in development_runtime tests (#29720) #29866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntime tests (#29720) * the dev server now returns 404s which would otherwise fail the tests * Correctly detect if there's any SSRed HTML as ___gatsby always has the focus wrapper child * Handle unicode paths like /안녕 * Properly escape paths with special characters in it * Enable DEV_SSR for everyone * Fix status in test * Revert to 20% rollout * revert changes for 100% rollout * test this (cherry picked from commit 114e006)
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Mar 1, 2021
vladar
removed
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Mar 1, 2021
Production runtime |
vladar
approved these changes
Mar 1, 2021
This was referenced Mar 9, 2021
This was referenced Mar 9, 2021
This was referenced Mar 9, 2021
This was referenced Mar 9, 2021
This was referenced Apr 15, 2024
This was referenced May 16, 2024
This was referenced Oct 13, 2024
This was referenced Oct 15, 2024
This was referenced Oct 15, 2024
This was referenced Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting #29720 to the 3.0 release branch
(cherry picked from commit 114e006)