Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): Fix various small DEV_SSR bugs exposed in development_runtime tests (#29720) #29866

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

gatsbybot
Copy link
Collaborator

Backporting #29720 to the 3.0 release branch

(cherry picked from commit 114e006)

…ntime tests (#29720)

* the dev server now returns 404s which would otherwise fail the tests

* Correctly detect if there's any SSRed HTML as ___gatsby always has the focus wrapper child

* Handle unicode paths like /안녕

* Properly escape paths with special characters in it

* Enable DEV_SSR for everyone

* Fix status in test

* Revert to 20% rollout

* revert changes for 100% rollout

* test this

(cherry picked from commit 114e006)
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 1, 2021
@vladar vladar removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 1, 2021
@vladar
Copy link
Contributor

vladar commented Mar 1, 2021

Production runtime redirect tests failing because they are flaky. Ignoring for now but we need to fix these flaky tests eventually 😒

@vladar vladar merged commit f070422 into release/3.0 Mar 1, 2021
@vladar vladar deleted the backport-3.0-29720 branch March 1, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants