fix(gatsby): also include default-site-plugin #33472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
wardpeet
added
gatsby 4
and removed
status: triage needed
LekoArts
approved these changes
Oct 11, 2021
|
I'm experimenting here #33484. So yes not a concern for this PR. |
wardpeet
added a commit
to herecydev/gatsby
that referenced
this pull request
Oct 29, 2021
axe312ger
pushed a commit
that referenced
this pull request
Nov 9, 2021
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We should also include default gatsby-node inside the query-engine for people who have schema APIs in their root.
This can make engines less reliable when people are doing fs.readFile in the global scope, dsg/ssr will not be able to find these files. I tried doing treeshaking but engines speed blew up so I have to look into another way.
Documentation
Related Issues