feat(gatsby): remove unused exports from query-engine #33484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
wardpeet
changed the title
wardpeet
added
gatsby 4
and removed
status: triage needed
wardpeet
changed the base branch from
master
to
remove/unused-exports-remove-api
wardpeet
force-pushed
the
tmp/treeshake-query-engine
branch
from
d7c04ee
to
ea2a625
Compare
wardpeet
force-pushed
the
tmp/treeshake-query-engine
branch
from
8f5e7b0
to
bb94599
Compare
LekoArts
approved these changes
Dec 9, 2021
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes all lifecycles except the ones we care about for queryEngine.
Drops from 45mb to 37,8mb for .com. Speed wise it was more or less these same as before. A few seconds got shaved.