fix(gatsby-source-drupal): Add timeout in case of stalled API requests #33668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
KyleAMathews
added
topic: source-drupal
KyleAMathews
commented
Oct 25, 2021
| @@ -253,7 +257,7 @@ ${JSON.stringify(webhookBody, null, 4)}` | |||
|
|
|||
| // lastFetched isn't set so do a full rebuild. | |||
| if (!lastFetched) { | |||
| setPluginStatus({ lastFetched: new Date().getTime() }) | |||
| setPluginStatus({ lastFetched: Math.floor(new Date().getTime() / 1000) }) | |||
There was a problem hiding this comment.
Also fix the timestamp creation as JS uses milliseconds and PHP uses seconds.
wardpeet
pushed a commit
to herecydev/gatsby
that referenced
this pull request
Oct 29, 2021
gatsbyjs#33668) * feat(gatsby-source-drupal): More ports from customer fixes * cleanups
axe312ger
pushed a commit
that referenced
this pull request
Nov 9, 2021
#33668) * feat(gatsby-source-drupal): More ports from customer fixes * cleanups
This was referenced Jun 6, 2022
This was referenced Jun 7, 2022
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We observe stalled API requests sometimes on customer sites. Adding a timeout ensures these don't block sourcing.