fix(gatsby-source-drupal): Bump timeout from 15s to 30s to avoid unnecessary API request timeouts #34035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
removed
the
status: triage needed
|
Please wait for the resolution of the issue first, this PR is until then a bit premature. Thanks! |
|
@LekoArts he and I have already talked about making this change so we're good actually 👍 |
KyleAMathews
changed the title
|
This would be better to be configurable (with fallback to those 30s). For example on some cases with local development of Drupal with Docker for Mac we would like to bypass this hardcoded value. Preferable is timeout per resource but global is still better than hardcoded timeout). |
|
@kmajzlik could you create a new issue to discuss this? |
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
Co-authored-by: Joe Stramel <joestramel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #34034
#33668 added a timeout of 15s so if API requests stall, we catch those and retry them. But in practice, this doesn't seem long enough as some requests hit the timeout consistently. We'll switch the timeout to 30s to see if this resolves the issue.