-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update gatsby-adapter-netlify version manifest #38745
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Dec 7, 2023
pieh
added
topic: adapters
Related to Gatsby Adapters
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Dec 7, 2023
MarcL
approved these changes
Dec 7, 2023
pieh
added
the
bot: merge on green
Gatsbot will merge these PRs automatically when all tests passes
label
Dec 7, 2023
pieh
added a commit
that referenced
this pull request
Dec 7, 2023
(cherry picked from commit 268a640)
pieh
added a commit
that referenced
this pull request
Dec 7, 2023
This was referenced Dec 14, 2023
This was referenced Dec 29, 2023
This was referenced Feb 3, 2024
This was referenced Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bot: merge on green
Gatsbot will merge these PRs automatically when all tests passes
topic: adapters
Related to Gatsby Adapters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#38666 swapped order of adapting (which does some artefacts in
public
moving) and cache storing, however newest adapter is being installed for gatsby versions before that causing failures on cached builds as restored artefacts are not in placegatsby
expect them to be. This mostly impacts dynamic SSG routes (matchPath
) but would also impact cases withpathPrefix
and non-defaulttrailingSlash
optionsFor now this is quick way so at least auto installation doesn't install incompatible adapter version for gatsby versions before above PR.
Documentation
Tests
Related Issues
https://answers.netlify.com/t/gatsby-build-error-error-loading-a-result-for-the-page-query-in-path-query-was-not-run-and-no-cached-result-was-found/107522/13
FRA-167