Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): allow gatsby-adapter-netlify@">=1.0.0 <=1.0.3" for gatsby@<5.12.10 #38758

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Dec 15, 2023

Description

#38745 only allowed gatsby-adapter-netlify@1.0.3 for gatsby@">=5.0.0 <5.12.10" versions. While that is fine when adapter is auto installed - it cause problems for users that already have lower version of adapter installed - see #38752.

This is just quick relaxing of version range and there will be more follow up work done to prevent broken deploys in the future as mentioned in the issue - however that requires more work/time and more testing.

This was tested with monkey-patching adapters code (we do pull adapters manifest from @latest npm version, so I just hardcoded this change instead of pulling) and installation still worked fine:

> gatsby -v 
Gatsby version: 5.12.4
> netlify build --offline
[...]
success Installing Netlify adapter (gatsby-adapter-netlify@>=1.0.0 <=1.0.3) - 4.967s
info If you plan on staying on this deployment platform, consider installing gatsby-adapter-netlify as a dependency in your project. This will give you faster and more robust
installs.
info Using gatsby-adapter-netlify adapter
[...]
> cd .cache/adapters && npm list gatsby-adapter-netlify
gatsby-adapters@1.0.0 /Users/misiek/test/netlify-gatsby-matchpath-minimal-repro/.cache/adapters
└── gatsby-adapter-netlify@1.0.3

Documentation

Tests

Related Issues

Helps with #38752

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 15, 2023
@pieh pieh added topic: adapters Related to Gatsby Adapters and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Dec 15, 2023
@pieh pieh added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Dec 15, 2023
@gatsbybot gatsbybot merged commit 1953e5c into master Dec 15, 2023
34 checks passed
@gatsbybot gatsbybot deleted the pieh-patch-2 branch December 15, 2023 10:41
pieh added a commit that referenced this pull request Dec 15, 2023
This was referenced Jan 8, 2024
This was referenced May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: adapters Related to Gatsby Adapters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants