-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update sharp to ^0.21.0
#8898
Conversation
Bumping sharp from |
Thanks @lovell! Is there any breaking changes we should worry about? |
Based on a quick scan of the - .resize(options.width, options.height)
- .crop(options.cropFocus)
+ .resize(options.width, options.height, {
+ position: options.cropFocus
+ }) Full changelog at http://sharp.pixelplumbing.com/en/stable/changelog/#v0210-4th-october-2018 |
@WaylonWalker would you be up for bumping |
@pieh I attempted, but am getting confused with some of the errors. I worked through the ones that seemed obvious to me. Some things seem unrelated, some seem related to node versions (testing setup??). Probably doesn't help that I am on a 40 kbps network at the moment, and working from the github ui only.. |
Dependency changes are hard to test currently, I will get on it - thanks for doing what You already did! |
Thanks @pieh, it looks very tricky. Especially not being too familiar with the codebase. Let me know if there is anything else I can do. |
@WaylonWalker looks like the commit histories are a little screwy. Trying to iron it out, and then I'll test this locally. Thanks for your patience! |
Well this was fun! 😅 I somehow managed to wipe the history, but I should have all the commits (and a successful merge) in WaylonWalker#1, so once we merge that we can re-open this! Also so thankful for |
this is mostly same PR as #8898 with couple of tweaks (upgrading sharp everywhere so all packages use same version). Credits go to @WaylonWalker
this is mostly same PR as gatsbyjs#8898 with couple of tweaks (upgrading sharp everywhere so all packages use same version). Credits go to @WaylonWalker
This will help folks having installation issues on windows resolve without opening an issue. This issue has been seen in Issue lovell/sharp#1382, lovell/sharp#1387, and in #8325.