chore: upgrade sharp to 0.21.0 #9318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help folks having installation issues on windows resolve without opening an issue. This issue has been seen in Issue lovell/sharp#1382, lovell/sharp#1387, and in gatsbyjs#8325.
Changes per @lovell to update to sharp ```^0.21.0``` - .resize(options.width, options.height) - .crop(options.cropFocus) + .resize(options.width, options.height, { + position: options.cropFocus + }) ** note I was unable to clone the full repo due to poor connection... attempting from the github interface.
added trailing commas to linting test
added options to jobs.forEach block
KyleAMathews
approved these changes
Oct 23, 2018
shannonbux
approved these changes
Oct 23, 2018
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
this is mostly same PR as gatsbyjs#8898 with couple of tweaks (upgrading sharp everywhere so all packages use same version). Credits go to @WaylonWalker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is mostly same PR as #8898 with couple of tweaks (upgrading sharp everywhere so all packages use same version). Credits go to @WaylonWalker