Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Pathname to determine if path is absolute #216

Closed
wants to merge 1 commit into from

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Apr 12, 2023

🦟 Bug fix

Fixes #

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #216 (1480d12) into ign-launch5 (aa5f470) will not change coverage.
The diff coverage is n/a.

❗ Current head 1480d12 differs from pull request most recent head e6e7805. Consider uploading reports for the commit e6e7805 to get more accurate results

@@             Coverage Diff              @@
##           ign-launch5     #216   +/-   ##
============================================
  Coverage        58.83%   58.83%           
============================================
  Files                3        3           
  Lines              396      396           
============================================
  Hits               233      233           
  Misses             163      163           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@azeey azeey self-assigned this Apr 12, 2023
@azeey azeey added beta Targeting beta release of upcoming collection and removed beta Targeting beta release of upcoming collection labels Jul 31, 2023
@nkoenig
Copy link
Contributor

nkoenig commented Jan 16, 2024

@azeey This has been around for a while. Do you want to close this PR? Alternatively I could take it over if you can give me some context about what you were attempting to do.

@azeey
Copy link
Contributor Author

azeey commented Jan 16, 2024

I was trying to get UNIT_ign/gz_TEST to run on windows. More context here. But there are additional things to fix before this is possible: support multi-config cmake builds (similar to gazebosim/sdformat#1339) and maybe standalone executables.

I think only gz-transport runs those tests on windows, so perhaps we should disable them for now until we implement standalone executables for gz-launch.

@azeey
Copy link
Contributor Author

azeey commented May 28, 2024

Closing since the changes were added in #255.

@azeey azeey closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants