Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install ruby commands on Windows #1339

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Install ruby commands on Windows #1339

merged 4 commits into from
Oct 23, 2023

Conversation

Voldivh
Copy link
Contributor

@Voldivh Voldivh commented Oct 12, 2023

🦟 Bug fix

Fixes #1321

Summary

Make sure to add_subdirectory(cmd) on Windows. This requires generating the .rb and .yaml files to folders unique to $<CONFIG>.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Oct 12, 2023
Copy link
Collaborator

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI!

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
@Voldivh Voldivh force-pushed the voldivh/win_install_cmd branch from 775e60b to c63dbd7 Compare October 16, 2023 20:47
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Voldivh and others added 2 commits October 17, 2023 13:25
Use a compile definition for setting `GZ_CONFIG_PATH`
Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #1339 (e1f98b4) into sdf13 (f425694) will not change coverage.
The diff coverage is n/a.

❗ Current head e1f98b4 differs from pull request most recent head fa91043. Consider uploading reports for the commit fa91043 to get more accurate results

@@           Coverage Diff           @@
##            sdf13    #1339   +/-   ##
=======================================
  Coverage   87.58%   87.58%           
=======================================
  Files         128      128           
  Lines       17090    17090           
=======================================
  Hits        14968    14968           
  Misses       2122     2122           

@azeey
Copy link
Collaborator

azeey commented Oct 17, 2023

Looking at the windows CI, I don't see UNIT_gz_TEST, so I'm not sure if gz is found correctly on windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

gz sdf still not on Windows?
2 participants