-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install ruby commands on Windows #1339
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI!
Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
775e60b
to
c63dbd7
Compare
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Use a compile definition for setting `GZ_CONFIG_PATH`
Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
Codecov Report
@@ Coverage Diff @@
## sdf13 #1339 +/- ##
=======================================
Coverage 87.58% 87.58%
=======================================
Files 128 128
Lines 17090 17090
=======================================
Hits 14968 14968
Misses 2122 2122 |
Looking at the windows CI, I don't see |
🦟 Bug fix
Fixes #1321
Summary
Make sure to
add_subdirectory(cmd)
on Windows. This requires generating the.rb
and.yaml
files to folders unique to$<CONFIG>
.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.