Mesh conversion: define intermediate prim as Scope #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When converting parsing a mesh from SDFormat, an extra level of USD hierarchy is added with the mesh name. To ensure all prims have a type, define the intermediate prim type as a Scope, as recommended by a USD expert. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
|
I was looking at a USD file containing meshes exported from SDFormat in the Isaac Sim GUI, and it lists the USD prim type in the entity tree widget. Before this change, the intermediate "geometry" prim has no type listed, but with this change, it has type |
ahcorde
approved these changes
Oct 2, 2024
|
https://github.com/Mergifyio backport fortress garden |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 3, 2024
When converting parsing a mesh from SDFormat, an extra level of USD hierarchy is added with the mesh name. To ensure all prims have a type, define the intermediate prim type as a Scope, as recommended by a USD expert. Signed-off-by: Steve Peters <scpeters@openrobotics.org> (cherry picked from commit 178e136)
mergify bot
pushed a commit
that referenced
this pull request
Oct 3, 2024
When converting parsing a mesh from SDFormat, an extra level of USD hierarchy is added with the mesh name. To ensure all prims have a type, define the intermediate prim type as a Scope, as recommended by a USD expert. Signed-off-by: Steve Peters <scpeters@openrobotics.org> (cherry picked from commit 178e136)
This was referenced Oct 3, 2024
ahcorde
pushed a commit
that referenced
this pull request
Oct 3, 2024
When converting parsing a mesh from SDFormat, an extra level of USD hierarchy is added with the mesh name. To ensure all prims have a type, define the intermediate prim type as a Scope, as recommended by a USD expert. Signed-off-by: Steve Peters <scpeters@openrobotics.org> (cherry picked from commit 178e136) Co-authored-by: Steve Peters <scpeters@openrobotics.org>
ahcorde
pushed a commit
that referenced
this pull request
Oct 3, 2024
When converting parsing a mesh from SDFormat, an extra level of USD hierarchy is added with the mesh name. To ensure all prims have a type, define the intermediate prim type as a Scope, as recommended by a USD expert. Signed-off-by: Steve Peters <scpeters@openrobotics.org> (cherry picked from commit 178e136) Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
When converting parsing a mesh from SDFormat, an extra level of USD hierarchy is added with the mesh name. To ensure all prims have a type, define the intermediate prim type as a Scope, as recommended by a USD expert.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.