Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RVK instance sometimes shows no mapping editor #514

Closed
nichtich opened this issue Nov 6, 2019 · 2 comments
Closed

RVK instance sometimes shows no mapping editor #514

nichtich opened this issue Nov 6, 2019 · 2 comments
Labels
bug Something is broken
Milestone
1.2.0

Comments

@nichtich
Copy link
Member

nichtich commented Nov 6, 2019 •
edited
Loading

Several users had an empty Mapping Editor at https://coli-conc.gbv.de/cocoda/rvk/. Spotted at least on Windows with Firefox but not always. May be related to #513
@nichtich nichtich added the bug Something is broken label Nov 6, 2019
@nichtich nichtich added this to the 1.2.0 milestone Nov 6, 2019
@stefandesu
Copy link
Member

Happens to me in Firefox as well. I don't think it has anything to do with #513 though, I see a lot of error message on the console that look like there's something wrong with the configuration. I think I can figure it out.

@stefandesu stefandesu mentioned this issue Nov 7, 2019
Closed
stefandesu added a commit that referenced this issue Nov 7, 2019
@stefandesu
Fix issue with mapping registry (#514)
0dc5263 
This caused the getter for the current mapping registry to return null if the user has not selected a registry and is not authorized to save into any registry.

Needs to be fixed properly at some point in #515.
@stefandesu
Copy link
Member

This should be fixed now. The bug happened where the user has not selected a mapping registry and was also not authorized to save into any mapping registry. This hasn't happened before because we also had local mappings, so the fallback for the getter for the current mapping registry worked. For now, I adjusted the fallback to use any registry which allows saving mappings even if the user is currently not authorized.

This should be fixed properly at some point, see #515.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is broken
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
2 participants
@nichtich @stefandesu