Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't assume that a mapping registry to save mappings exists #515

Closed
stefandesu opened this issue Nov 7, 2019 · 3 comments
Closed

Don't assume that a mapping registry to save mappings exists #515

stefandesu opened this issue Nov 7, 2019 · 3 comments
Labels
bug Something is broken cleanup code cleanup, refactoring, testing... low priority maybe later
Milestone
1.5.0

Comments

@stefandesu
Copy link
Member

If there is no mapping registry in which to save mappings, the application will be very buggy because there are multiple locations in the code where it is assumed that the getter for the current mapping registry does not return null. It should instead consider the case that there is no registry in which to save mappings at all. Also, Mapping Editor does not need to be shown in this case, as well as all buttons related to editing/saving mappings in Mapping Browser.

This came out of #514.
@stefandesu stefandesu added bug Something is broken cleanup code cleanup, refactoring, testing... low priority maybe later labels Nov 7, 2019
stefandesu added a commit that referenced this issue Nov 7, 2019
@stefandesu
Fix issue with mapping registry (#514)
0dc5263 
This caused the getter for the current mapping registry to return null if the user has not selected a registry and is not authorized to save into any registry.

Needs to be fixed properly at some point in #515.
@stefandesu stefandesu mentioned this issue Nov 7, 2019
Closed
@nichtich
Copy link
Member

nichtich commented Nov 7, 2019

We could also allow to disable the currently selected registry so no registry is selected for writing.

@stefandesu
Copy link
Member Author

We could also allow to disable the currently selected registry so no registry is selected for writing.

Would there be a specific use case for this? Not that I disagree, just trying to play devil's advocate.

@stefandesu stefandesu added this to the 1.5.0 milestone Nov 22, 2021
@stefandesu
Copy link
Member Author

Done with some recently changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is broken cleanup code cleanup, refactoring, testing... low priority maybe later
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
2 participants
@nichtich @stefandesu