Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support decomposing compound concepts #524

Closed
nichtich opened this issue Nov 27, 2019 · 8 comments
Closed

Support decomposing compound concepts #524

nichtich opened this issue Nov 27, 2019 · 8 comments
Labels
backend Requires work on the backend feature Additional functionality

Comments

@nichtich
Copy link
Member

Both RVK and DDC support compound concepts. Concept Details should contain a tab to display which components a compound concept is build from. See https://coli-conc.gbv.de/coli-ana/ for a draft. This requires an additional web-service to query concept components for concepts of selected concept schemes.

@nichtich nichtich added feature Additional functionality backend Requires work on the backend labels Nov 27, 2019
@nichtich nichtich added this to the 1.8.0 milestone Nov 27, 2019
@nichtich nichtich modified the milestones: 1.8.0, 1.4.0 Dec 4, 2019
@nichtich
Copy link
Member Author

nichtich commented Jul 8, 2020

In K10plus decomposed DDC can be put into 045H/00, e.g. this record:

045F $e23$a700.9044

could get in addition:

045H/00 $e23$a700.9044$c700$f09044

Which in JSKOS is

{
  "notation": [ "700.9044" ],
  "memberList": [
    { "uri": "http://dewey.info/class/700/e23/", "notation": "700" },
    { "uri": "http://dewey.info/class/1--09044/e23/", "notation": "T1--09044" }
  ]
}

@nichtich
Copy link
Member Author

See https://github.com/gbv/coli-ana-api for a draft of an API to be included in Cocoda.

@stefandesu
Copy link
Member

Since the coli-ana API is now available (see https://github.com/gbv/coli-ana and https://coli-conc.gbv.de/coli-ana/app/), we could integrate it into Cocoda. I'm going to try and implement a basic interface. I wouldn't offer everything that the coli-ana interface offers, but rather link to it for a full analysis.

@stefandesu
Copy link
Member

stefandesu commented Mar 26, 2021

There's a first implementation in dev, see https://coli-conc.gbv.de/cocoda/dev/?fromScheme=http%3A%2F%2Fbartoc.org%2Fen%2Fnode%2F241&from=http%3A%2F%2Fdewey.info%2Fclass%2F103.02938764%2Fe23%2F for example.

Things missing:

  • Localization of interface text.
  • Note in case of incomplete analysis.
  • Maybe API links?
  • Deal with languages: Currently, if for some of the members in the analysis list there are English labels and the interface is in English, then those will be shown in English as well. That's probably how it should be, but then we should also load labels for the other members so that they are uniform in one language, if possible. (But for DDC specifically, this issue is even more complicated.)

@stefandesu
Copy link
Member

After we fix the issues with our CI, I suggest to release a new patch version with the current implementation of this. However, all the issues above should be fixed in a future update.

@stefandesu
Copy link
Member

The current implementation is now published with version 1.4.5. Since there's still some things to do, I will leave this issue open.

@stefandesu
Copy link
Member

stefandesu commented Aug 4, 2021

I just added a few improvements to the feature, including one that wasn't mentioned before: In certain cases (no concept information available => likely a custom built number and not part of the standard tables), the coli-ana tab is activated automatically.

Example: https://coli-conc.gbv.de/cocoda/dev/?fromScheme=http%3A%2F%2Fbartoc.org%2Fen%2Fnode%2F241&from=http%3A%2F%2Fdewey.info%2Fclass%2F001.09409%2Fe23%2F

I would suggest releasing another patch version with these changes as the last release before refactoring Cocoda to Vue 3.

@stefandesu
Copy link
Member

stefandesu commented Aug 4, 2021

There's still a bug: Second notations will not be saved correctly if the same concept was already loaded before as part of another analysis. For example, first open the analysis for 700.90440747471, then for 001.09409. Some concepts will have a much longer second notation that is applicable in this case.

The reason for this is that the concepts will be saved like every other concept, and once notation[1] is set, it won't be changed. Instead, the memberList of concepts should be kept independent of the other concepts. This, however, makes loading concept data a bit more difficult.

Edit: Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Requires work on the backend feature Additional functionality
Projects
None yet
Development

No branches or pull requests

2 participants