Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid response when no notations is supplied #66

Closed
nichtich opened this issue Jan 28, 2022 · 3 comments
Closed

Invalid response when no notations is supplied #66

nichtich opened this issue Jan 28, 2022 · 3 comments
Labels
bug Something is broken

Comments

@nichtich
Copy link
Member

curl https://coli-conc.gbv.de/coli-ana/dev/analyze
[object Object]
@nichtich nichtich added the bug Something is broken label Jan 28, 2022
@stefandesu
Copy link
Member

I'm confused. First of all, if I try the same locally, I get a proper JSON response. Looking at the code, it seems like it was changed so that if no notation parameter is given, it does a member lookup (something that we removed from the interface some time ago), and if search is also not given (which is used by the lookup), it will just return the first X results from the database.

I don't know why it's different locally on my machine, and I also don't know if we still need the lookup functionality. What we could do is to only run the lookup if notation is empty and search is not empty.

@nichtich
Copy link
Member Author

I have not looked at the code but in any case we can fully remove member lookup.

stefandesu added a commit that referenced this issue Jan 28, 2022
@stefandesu
Copy link
Member

curl https://coli-conc.gbv.de/coli-ana/dev/analyze will now return an empty array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken
Projects
None yet
Development

No branches or pull requests

2 participants