Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switching to snapshot url #1076

Merged
merged 1 commit into from
May 7, 2019
Merged

switching to snapshot url #1076

merged 1 commit into from
May 7, 2019

Conversation

dougli1sqrd
Copy link
Contributor

No description provided.

@@ -44,7 +44,7 @@ target/go-ontology.json:

GAF_OWL = target/go-gaf.owl
$(GAF_OWL):
wget --no-check-certificate $(OBO)/go/extensions/go-gaf.owl -O $@.tmp && mv $@.tmp $@ && touch $@
wget --no-check-certificate $(OBO)/go/snapshot/extensions/go-gaf.owl -O $@.tmp && mv $@.tmp $@ && touch $@
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dougli1sqrd @kltm just curious will this point to the ontology file just built within the same run? Or is it the previous successful snapshot?

Copy link
Member

@kltm kltm May 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latter apparently. For doing the "single pass downloads" this would have to reference an internal URL. This should be no worse than what we had before.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess so but it seems like this will continue some of the mysterious behavior that requires two runs to get right.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And how!
The main "win" here is that there is less downloading and somewhat better traceability if something goes wrong as the imports are already there and haven't wandered off to a new version.

The end goal is to hit geneontology/pipeline#27 , which is a game changer. However, we'll have to fix some ontology plumbing problems before then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants