Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGI GPAD file is missing 'MGI:' in column 2 #199

Closed
ukemi opened this issue Aug 28, 2018 · 9 comments · Fixed by #201
Closed

MGI GPAD file is missing 'MGI:' in column 2 #199

ukemi opened this issue Aug 28, 2018 · 9 comments · Fixed by #201
Labels

Comments

@ukemi
Copy link

ukemi commented Aug 28, 2018

Recently column 2 in the GPAD output has been changed so that identifiers no longer contain the 'MGI:'. Instead, they just have the numerical portion of the identifier.

https://build.berkeleybop.org/job/export-lego-to-gpad-sparql/lastSuccessfulBuild/artifact/legacy/mgi.gpad

@kltm
Copy link
Member

kltm commented Aug 29, 2018

@cmungall @balhoff Has there been any upstream change to explain this?

@kltm kltm added the question label Aug 29, 2018
@balhoff
Copy link
Member

balhoff commented Aug 29, 2018

There has been change in the JSON-LD context files (geneontology/go-site#617). I will need to dig further to see if that is the culprit.

@ukemi
Copy link
Author

ukemi commented Aug 30, 2018

@loricorbani

@balhoff
Copy link
Member

balhoff commented Aug 30, 2018

I think this is an issue with the GO JSON-LD context, which is included in Minerva and also available at https://github.com/prefixcommons/biocontext/blob/master/registry/go_context.jsonld

The entry for MGI is:

"MGI": "http://identifiers.org/mgi/MGI:"

The identifiers in the models look like http://identifiers.org/mgi/MGI:1919103. So when this is shortened it becomes MGI:1919103, which is split to go into the GPAD columns.

@cmungall shouldn't this be: "MGI": "http://identifiers.org/mgi/"

@balhoff
Copy link
Member

balhoff commented Aug 30, 2018

This behavior isn't appearing in Noctua right now, but it may have been a while since Minerva was updated there.

@ukemi
Copy link
Author

ukemi commented Aug 30, 2018

In Noctua I see the identifiers being of the correct prefix--identifier format. Looking at:
http://noctua.berkeleybop.org/editor/graph/gomodel:5b318d0900000110

The enabled by individual for Cdc42 is represented as '[MGI:MGI:106211] Cdc42 mouse' this should parse correctly into MGI in column 1 and MGI:106211 in column 2.

@pgaudet
Copy link

pgaudet commented Aug 30, 2018

So this is resolved ?

@cmungall
Copy link
Member

curl -L -s https://build.berkeleybop.org/job/export-lego-to-gpad-sparql/lastSuccessfulBuild/artifact/legacy/mgi.gpad | grep MGI

no, not resolved

@balhoff
Copy link
Member

balhoff commented Sep 4, 2018

This should be resolved now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants