Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[camt.053] RelatedAgent BIC #83

Closed
zembrowski opened this issue Jul 16, 2019 · 1 comment
Closed

[camt.053] RelatedAgent BIC #83

zembrowski opened this issue Jul 16, 2019 · 1 comment
Labels
enhancement help wanted

Comments

@zembrowski
Copy link

The xml tag for the RelatedAgents BIC is named in camt.053(.001.04) "BICFI".

I noticed, that camt.052 uses a "BIC" xml tag and is being tested with unit tests. For camt.053 an empty string is getting returned, as there is no "BIC" and no unit test. Is there a quick way to retrieve the BICFI for camt.053?

Thanks in advance for your response.
@zembrowski zembrowski mentioned this issue Jul 16, 2019
Closed
@PowerKiKi
Copy link
Collaborator

I don't think there is any way to get BICFI with current code.

I would suggest you to submit a new PR that adds an abstract method \Genkgo\Camt\Decoder\EntryTransactionDetail::getBIC that is implemented as needed in each inheriting classes according to CAMT version. Or alternatively implement the most common version in the parent class and override only in the rare cases that differ.

And then of course use that new method in addRelatedAgents.

If you cover all of that with unit tests, I'll merge you PR (after reviews of course).

tlamy pushed a commit to tlamy/camt that referenced this issue Oct 11, 2023
fix(genkgo#83): RelatedAgents' BIC may be in BICFI instead of BIC node
bdfc742
@tlamy tlamy mentioned this issue Oct 11, 2023
Merged
Alvyre pushed a commit to stadline/camt that referenced this issue Oct 9, 2024
@tlamy @PowerKiKi @Alvyre
fix(genkgo#83): RelatedAgents' BIC may be in BICFI instead of BIC node (
dfe88d7 
genkgo#150)

RelatedAgents' BIC is also available in CAMT 054

Because the RelatedAgents' BIC may be in BICFI instead of BIC node

Fixes genkgo#83
---------

Co-authored-by: Thomas Lamy <thomas.lamy@iventuregroup.com>
Co-authored-by: Adrien Crivelli <adrien.crivelli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PowerKiKi @zembrowski