Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#83): RelatedAgents' BIC may be in BICFI instead of BIC node #150

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

tlamy
Copy link
Contributor

@tlamy tlamy commented Oct 11, 2023

This fixes issue #83 for us, where at least in the camt.054.001.08 documents we receive the related agents' BIC are in BICFI nodes.
Test cases are also modified of course.

@tlamy
Copy link
Contributor Author

tlamy commented Dec 19, 2023

@PowerKiKi Would you mind to review the PR?

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.28%. Comparing base (57a5878) to head (f829a59).
Report is 1 commits behind head on master.

❗ Current head f829a59 differs from pull request most recent head 20363b9. Consider uploading reports for the commit 20363b9 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #150      +/-   ##
============================================
+ Coverage     83.22%   83.28%   +0.06%     
- Complexity      680      682       +2     
============================================
  Files            81       81              
  Lines          1657     1663       +6     
============================================
+ Hits           1379     1385       +6     
  Misses          278      278              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PowerKiKi PowerKiKi merged commit 08ff6d7 into genkgo:master Mar 22, 2024
7 checks passed
@PowerKiKi
Copy link
Collaborator

Sorry it took so long, but it's been released: https://github.com/genkgo/camt/releases/tag/2.7.0

Alvyre pushed a commit to stadline/camt that referenced this pull request Oct 9, 2024
genkgo#150)

RelatedAgents' BIC is also available in CAMT 054

Because the RelatedAgents' BIC may be in BICFI instead of BIC node

Fixes genkgo#83
---------

Co-authored-by: Thomas Lamy <thomas.lamy@iventuregroup.com>
Co-authored-by: Adrien Crivelli <adrien.crivelli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants