add dockerfile to containerize conman #10
Conversation
also add git to docker build env. Also added docker-devel script to make it easier to use conman inside the container.
There was a problem hiding this comment.
This looks good already, thanks. Two things before we move forward:
- Can you make sure the created executable is in the PATH environment so that users can start models wherever without knowing the location of the executable?
- Can you upload the generated docker image to your account already? I would like to test the docker image before merging this PR.
docker-devel
Outdated
| @@ -0,0 +1,3 @@ | |||
| #!/bin/sh | |||
|
|
|||
| docker run -it --rm -v $HOME/conman:/home/conman_user/work conman | |||
There was a problem hiding this comment.
please add a newline at the end of the file (VS code tends to not store with ending newline and github complains about it).
docker/conman/Dockerfile
Outdated
|
|
||
| RUN make | ||
|
|
||
| WORKDIR /home/conman_user |
docker/conman/Dockerfile
Outdated
| WORKDIR /home/conman_user/conman/src | ||
|
|
||
| RUN make | ||
|
|
||
| WORKDIR /home/conman_user |
There was a problem hiding this comment.
You could simplify this without change of functionality as:
| WORKDIR /home/conman_user/conman/src | |
| RUN make | |
| WORKDIR /home/conman_user | |
| RUN cd src; make |
There was a problem hiding this comment.
Very nice, almost ready except for my small comments.
However, when I try to execute your container after pulling from docker hub I get the following error message:
exec /home/conman_user/conman/conman: exec format error
if I run without a command, or
exec /bin/bash: exec format error
if I start bash explicitly.
This looks as if the image was built for the wrong architecture, but the tag on docker hub says it was build for linux/amd64. How did you create the linux/amd64 image? Does the image run on your system? For comparison your image for geodynamics/mag runs fine for me.
docker-devel
Outdated
| #!/bin/sh | ||
|
|
||
| docker run -it --rm -v $HOME/conman:/home/conman_user/work conman |
There was a problem hiding this comment.
What is the purpose of this file?
| @@ -0,0 +1 @@ | |||
| This container hosts a built version of conman. | |||
There was a problem hiding this comment.
Please include command to run the container here (the line from the docker-devel file above).
I built both images the same way using the --platform=linux/amd64 tag. Both images run on my machine, and both give a warning that the images' platform was built for amd64. I wonder if the conman image won't run for you because I pushed an arm64 image to jbakerdunn/conman before later updating the image with one built for amd64. Maybe some of the layers were not updated? I'll try deleting jbakerdunn/conman and reuploading the conman image. |
Co-authored-by: Rene Gassmoeller <rene.gassmoeller@mailbox.org>
|
This looks good now, thanks! |
Also add git to build environment dockerfile.
Added the docker-devel script to make it easier to use conman inside the container.