Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dockerfile to containerize conman #10

Merged
merged 4 commits into from
Apr 15, 2024
Merged

add dockerfile to containerize conman #10

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d283613
add dockerfile to containerize conman
JarettBakerDunn Mar 31, 2024
2652b7c
add path env for conman
JarettBakerDunn Apr 3, 2024
6c63680
move docker-devel command to README
JarettBakerDunn Apr 11, 2024
de97493
Update docker/conman/README.md
JarettBakerDunn Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docker-devel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#!/bin/sh

docker run -it --rm -v $HOME/conman:/home/conman_user/work conman
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a newline at the end of the file (VS code tends to not store with ending newline and github complains about it).

1 change: 1 addition & 0 deletions docker/conman-buildenv-bionic/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@ RUN apt update && \
DEBCONF_NONINTERACTIVE_SEEN='true' \
apt install --yes \
build-essential \
git \
gfortran
17 changes: 17 additions & 0 deletions docker/conman/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
FROM geodynamics/conman-buildenv-bionic:latest

RUN useradd \
--create-home \
conman_user

USER conman_user

WORKDIR /home/conman_user

RUN git clone 'https://github.com/geodynamics/conman.git'

WORKDIR /home/conman_user/conman/src

RUN make

WORKDIR /home/conman_user
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could simplify this without change of functionality as:

Suggested change
WORKDIR /home/conman_user/conman/src
RUN make
WORKDIR /home/conman_user
RUN cd src; make

1 change: 1 addition & 0 deletions docker/conman/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This container hosts a built version of conman.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include command to run the container here (the line from the docker-devel file above).

Loading