Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.5 regression #149

Closed
joe-graham-oag opened this issue May 13, 2020 · 3 comments · Fixed by #150
Closed

Python 3.5 regression #149

joe-graham-oag opened this issue May 13, 2020 · 3 comments · Fixed by #150

Comments

@joe-graham-oag
Copy link

image
Importing contextily on Python 3.5 results in this syntax error due to the use of f-strings, which were introduced in Python 3.6.
@darribas
Copy link
Collaborator

darribas commented May 13, 2020 •
edited
Loading

Hello, thanks for the report!

Yes, that's correct, we only support 3.6 and above (currently testing on 3.6 and 3.7). We should probably make it more explicit on the README.md.

@joe-graham-oag
Copy link
Author

That would be appreciated, as well as changing the python_requires field in setup.py.

darribas added a commit to darribas/contextily that referenced this issue May 14, 2020
@darribas
Fix geopandas#149
9a8b652
@darribas
Copy link
Collaborator

Thanks! PR issued over at #150. Should be on master soon

@darribas darribas mentioned this issue May 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Require Python 3.6 as minimum version (#149) darribas/contextily
2 participants
@darribas @joe-graham-oag