Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Python 3.6 as minimum version (#149) #150

Merged
merged 1 commit into from
May 31, 2020

Conversation

darribas
Copy link
Collaborator

@darribas darribas commented May 14, 2020

This PR clarifies the version of Python 3 required for running contextily. It also updates the conf.py to reflect Python 3.6 or above is required.

Fix #149

@ljwolf
Copy link
Member

ljwolf commented May 14, 2020

I think this may warrant a 1.0.post1 release on pypi, so that it gets picked up by conda-forge... this would require an update to the version?

@jorisvandenbossche
Copy link
Member

, so that it gets picked up by conda-forge... this would require an update to the version?

For conda-forge, we don't need a new version. We can update the reciple to require python 3.6 as minimum instead of python 3.5, and then only increase the "build number", not the version number.

Now, for pypi, this requires a release, yes.

@jorisvandenbossche jorisvandenbossche changed the title Fix #149 Require Python 3.6 as minimum version (#149) May 14, 2020
@jorisvandenbossche
Copy link
Member

Let's merge this, we can see about a bug fix release later

@jorisvandenbossche jorisvandenbossche merged commit d57c1b2 into geopandas:master May 31, 2020
jpn-- added a commit to jpn--/contextily that referenced this pull request Jan 8, 2021
…iles

* commit '3c26d5a16a094e8d5ae05f8e5a41f05278816daf':
  DOC: update for latest pydata-sphinx-theme (fix sidebar + use CSS variables) (geopandas#168)
  RLS: v1.0.1
  Fix resetting of extent with local files (geopandas#155) (geopandas#156)
  Add random user ID for Nominatim and allow arbitrary geocoder (geopandas#164)
  Close and reopen memfile dataset before WarpedVRT (geopandas#165)
  Fix use of rasterio MemoryFile (geopandas#163)
  DOC: Use Cape Town consistently in description and variable names (geopandas#154)
  Add matplotlib Framework classifier (geopandas#152)
  Require Python 3.6 as minimum version (geopandas#150)
  Add earthengine to docker for binder
  Example interfacing GEE with contextily (geopandas#147)
  DOC: add notebook about working with local files (geopandas#139)

# Conflicts:
#	tests/test_ctx.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.5 regression
3 participants