Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples added in the places_guide notebook (#143) #180

Merged
merged 3 commits into from
Jul 30, 2021
Merged

Examples added in the places_guide notebook (#143) #180

merged 3 commits into from
Jul 30, 2021

Conversation

chrstnbwnkl
Copy link
Contributor

First of all, thank you for creating and maintaining this handy package! I added some examples to showcase the PlaceAPI. Let me know whether this is anywhere close to what you had in mind! Feedback and suggestions always appreciated :–)

@darribas
Copy link
Collaborator

This is super cool @chrstnbwnkl!!! Thanks for contributing. This looks good to me, the only thing I'd ask to add further is to hook the notebook into the docs by adding it to the list at:

https://github.com/geopandas/contextily/blob/master/docs/index.rst

I'd problably place it after the general intro?

@darribas darribas merged commit ead2af2 into geopandas:master Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants