Fix clock offset scaling, especially in sp3 interpolation #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
|
Ha! You can merge without a review! 😀 |
Yeah, sorry but I was pretty sure about this one, and we had a very interesting pending discussion (see the Issue portal) that I wanted to update |
|
It's fine, just that a while ago you couldn't merge without a review and couldn't self-approve either. |
lnicola
reviewed
Mar 29, 2024
| @@ -82,15 +82,15 @@ mod test { | |||
| for (epoch, sv, clock) in sp3.sv_clock() { | |||
| assert_eq!(epoch, Epoch::from_str("2019-10-27T00:00:00 GPST").unwrap()); | |||
| if sv == sv!("C01") { | |||
| assert_eq!(clock, 63.035497, "bad clock data"); | |||
| assert!((clock - 63.035497E-6).abs() < 1E-9, "bad clock data"); | |||
There was a problem hiding this comment.
Not sure it's worth using it, but https://docs.rs/approx.
There was a problem hiding this comment.
Yeah I should look into adding this (only in test mode )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invalid Gregorian date: Carrywhile position-solving #219