Set levels with cloud from parent model #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update removes the requirement of using MODEL_GEOSCHEM if passing vertical grid from parent model. Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
# levels with cloud is now passed as an argument in Init_Cldj. Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
|
@yantosca, I applied the changes. Ready for another review. |
|
@lizziel: Also, the integration tests in GEOS-Chem for corresponding PR #2342 passed. Let me know when you merge this into the dev/7.7.2 branch and then I'll complete the GEOS-Chem PR merges into the no-diff-to-benchmark branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Lizzie Lundgren
Institution: Harvard University
Describe the update
This PR changes Cloud-J so that parameter LWEPAR (# levels with cloud) is passed from the parent model if not using Cloud-J standalone. This enables using Cloud-J in parent models with different vertical grids.
This update also more generalizes the condition in which vertical level information is passed from the parent model. Previously total number of vertical levels could only be set from the parent if using GEOS-Chem. New C-preprocessor switch CLOUDJ_STANDALONE allows removing MODEL_GEOSCHEM for that section.
Expected changes
This is a zero diff update for GEOS-Chem benchmarks.
Reference(s)
none
Related Github Issues and PRs
closes #16
geoschem/geos-chem#2342 (merge required for compatibility with this PR)