-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read number of levels with clouds used in photolysis from config file #2342
Read number of levels with clouds used in photolysis from config file #2342
Conversation
5cb776e
to
76f368b
Compare
…loud-j Updates include: - Add new Input_Opt setting Nlevs_Phot_Cloud - Set Input_Opt%Nlevs_Phot_Cloud from new setting in geoschem_config.yml photolysis menu - Move a few existing settings in input_opt_mod.F90 to photolysis menu since that is now where they are stored in geoschem_config.yml - Update all geoschem_config.yml templates. All use 34 as number of levels with clouds except CESM which uses 22. Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
76f368b
to
e91ce06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lizziel. This looks OK to merge. One thing, we will need to add the num_levs_with_cloud
YAML tag to the geoschem_config.rst
documentation page. We could do this in the docs/dev
branch though.
Integration tests are running |
All GEOS-Chem Classic integration tests passed: ==============================================================================
GEOS-Chem Classic: Execution Test Results
GCClassic #14397c6 GEOS-Chem submod update: Merge PR #2363 (Update setCommonRunSettings.sh)
GEOS-Chem #f78052f59 Merge PR #2342 (Read number of levels with clouds into Cloud-J)
HEMCO #2192e0e HEMCO 3.9.1 release
Using 24 OpenMP threads
Number of execution tests: 28
Submitted as SLURM job: 39073394
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% All tests were zero-diff w/r/t PR #2363 except:
|
All GCHP integration tests passed: ==============================================================================
GCHP: Execution Test Results
GCHP #9c77f30 GEOS-Chem submod update: Merge PR #2363 (Update setCommonRunSettings.sh)
GEOS-Chem #f78052f59 Merge PR #2342 (Read number of levels with clouds into Cloud-J)
HEMCO #
Number of execution tests: 11
Submitted as SLURM job: 39073425
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% Also, all tests were zero-diff w/r/t PR #2363. |
We now run a 2x2.5 ModelE2.1 (aka GCAP 2.0) full-chemistry simulation in the GCClassic integration tests. Only one scenario (SSP2-4.5) is evaluated here simply to ensure these future scenario simulations compile and run for 1 hour successfully. I will defer to @ltmurray for guidance on whether additional simulations are needed. The GCAP 2.0 integration test is passing off of 14.4.1, confirming that the fixes in #2342 should have resolved the issues of GCAP 2.0 not working in 14.0.0 (as reported by Lee Murray at IGC11). Sample integration test output: ``` ============================================================================== GEOS-Chem Classic: Execution Test Results GCClassic #c49fcec Submod updates: Merge GEOS-Chem PR #2353 and Cloud-J PR #19 GEOS-Chem #7e4001658 Merge PR #2369 (Fix several issues with satellite diagnostics) HEMCO #2192e0e HEMCO 3.9.1 release Using 24 OpenMP threads Number of execution tests: 29 Submitted as SLURM job: 40462513 ============================================================================== Execution tests: ------------------------------------------------------------------------------ gc_05x0625_NA_47L_merra2_CH4........................Execute Simulation....PASS gc_05x0625_NA_47L_merra2_fullchem...................Execute Simulation....PASS gc_2x25_ModelE2.1_fullchem..........................Execute Simulation....PASS ``` Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
We now run a 2x2.5 ModelE2.1 (aka GCAP 2.0) full-chemistry simulation in the GCClassic integration tests. Only one scenario (SSP2-4.5) is evaluated here simply to ensure these future scenario simulations compile and run for 1 hour successfully. I will defer to @ltmurray for guidance on whether additional simulations are needed. The GCAP 2.0 integration test is passing off of 14.4.1, confirming that the fixes in #2342 should have resolved the issues of GCAP 2.0 not working in 14.0.0 (as reported by Lee Murray at IGC11). Sample integration test output: ``` ============================================================================== GEOS-Chem Classic: Execution Test Results GCClassic #c49fcec Submod updates: Merge GEOS-Chem PR #2353 and Cloud-J PR #19 GEOS-Chem #7e4001658 Merge PR #2369 (Fix several issues with satellite diagnostics) HEMCO #2192e0e HEMCO 3.9.1 release Using 24 OpenMP threads Number of execution tests: 29 Submitted as SLURM job: 40462513 ============================================================================== Execution tests: ------------------------------------------------------------------------------ gc_05x0625_NA_47L_merra2_CH4........................Execute Simulation....PASS gc_05x0625_NA_47L_merra2_fullchem...................Execute Simulation....PASS gc_2x25_ModelE2.1_fullchem..........................Execute Simulation....PASS ``` Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
Name and Institution (Required)
Name: Lizzie Lundgren
Institution: Harvard University
Describe the update
This PR addresses the issue of hard-coding number of levels with cloud within Cloud-J photolysis. It fixes a bug where you can only use Cloud-J in GEOS-Chem at 72 levels. It goes with Cloud-J PR geoschem/Cloud-J#17 which now accepts this parameter from parent models.
Updates include:
Input_Opt
settingNlevs_Phot_Cloud
Input_Opt%Nlevs_Phot_Cloud
from new setting ingeoschem_config.yml
photolysis menuinput_opt_mod.F90
to photolysis menu since that is now where they are stored ingeoschem_config.yml
geoschem_config.yml
templates to include the new parameter.Expected changes
This is a zero diff update.
Reference(s)
None
Required companion PRs
geoschem/Cloud-J#17
Related Github issues
geoschem/Cloud-J#16