Fix libGeosCore.a not being built when NO_EXE=y #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update fixes an issue with the NO_EXE option introduced for coupling GEOS-Chem with WRF. The intended behavior is when coupled with other models, GEOS-Chem compilation is initialized with the NO_EXE=y option. The internal makefile flag EXE_NEEDED is thus set to 0, and the ./bin/geos executable building is inhibited: instead GEOS-Chem builds a libGeosCore.a for use by external models. There was a bug in the previous code where the ar crs command to build libGeosCore.a was executed when EXE_NEEDED eq to 1 and not 0, thus if NO_EXE=y, neither the geos executable nor the libGeosCore.a library was built. This update fixes this issue. Signed-off-by: Haipeng Lin <linhaipeng@pku.edu.cn>
4 tasks
yantosca
added a commit
that referenced
this pull request
Jul 9, 2024
This merge brings PR #2353 (Cloud-J error handling, by @lizziel) into the GEOS-Chem "no-diff-to-benchmark" development stream. This PR implements robust error handling for Cloud-J (i.e. error code passed all the way to the main program, for graceful shutdown). NOTE: Relies on Cloud-J PR #19, Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
msulprizio
added a commit
that referenced
this pull request
Jul 19, 2024
We now run a 2x2.5 ModelE2.1 (aka GCAP 2.0) full-chemistry simulation in the GCClassic integration tests. Only one scenario (SSP2-4.5) is evaluated here simply to ensure these future scenario simulations compile and run for 1 hour successfully. I will defer to @ltmurray for guidance on whether additional simulations are needed. The GCAP 2.0 integration test is passing off of 14.4.1, confirming that the fixes in #2342 should have resolved the issues of GCAP 2.0 not working in 14.0.0 (as reported by Lee Murray at IGC11). Sample integration test output: ``` ============================================================================== GEOS-Chem Classic: Execution Test Results GCClassic #c49fcec Submod updates: Merge GEOS-Chem PR #2353 and Cloud-J PR #19 GEOS-Chem #7e4001658 Merge PR #2369 (Fix several issues with satellite diagnostics) HEMCO #2192e0e HEMCO 3.9.1 release Using 24 OpenMP threads Number of execution tests: 29 Submitted as SLURM job: 40462513 ============================================================================== Execution tests: ------------------------------------------------------------------------------ gc_05x0625_NA_47L_merra2_CH4........................Execute Simulation....PASS gc_05x0625_NA_47L_merra2_fullchem...................Execute Simulation....PASS gc_2x25_ModelE2.1_fullchem..........................Execute Simulation....PASS ``` Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
lizziel
pushed a commit
that referenced
this pull request
Jul 30, 2024
We now run a 2x2.5 ModelE2.1 (aka GCAP 2.0) full-chemistry simulation in the GCClassic integration tests. Only one scenario (SSP2-4.5) is evaluated here simply to ensure these future scenario simulations compile and run for 1 hour successfully. I will defer to @ltmurray for guidance on whether additional simulations are needed. The GCAP 2.0 integration test is passing off of 14.4.1, confirming that the fixes in #2342 should have resolved the issues of GCAP 2.0 not working in 14.0.0 (as reported by Lee Murray at IGC11). Sample integration test output: ``` ============================================================================== GEOS-Chem Classic: Execution Test Results GCClassic #c49fcec Submod updates: Merge GEOS-Chem PR #2353 and Cloud-J PR #19 GEOS-Chem #7e4001658 Merge PR #2369 (Fix several issues with satellite diagnostics) HEMCO #2192e0e HEMCO 3.9.1 release Using 24 OpenMP threads Number of execution tests: 29 Submitted as SLURM job: 40462513 ============================================================================== Execution tests: ------------------------------------------------------------------------------ gc_05x0625_NA_47L_merra2_CH4........................Execute Simulation....PASS gc_05x0625_NA_47L_merra2_fullchem...................Execute Simulation....PASS gc_2x25_ModelE2.1_fullchem..........................Execute Simulation....PASS ``` Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update fixes an issue with the NO_EXE option introduced for
coupling GEOS-Chem with WRF.
The intended behavior is when coupled with other models, GEOS-Chem
compilation is initialized with the
NO_EXE=yoption. The internalmakefile flag
EXE_NEEDEDis thus set to 0, and the ./bin/geos executablebuilding is inhibited: instead GEOS-Chem builds a
libGeosCore.afor useby external models.
There was a bug in the previous code where the
ar crs ...command to buildlibGeosCore.awas executed whenEXE_NEEDEDeq to 1 and not 0, thus ifNO_EXE=y, neither thegeosexecutable nor thelibGeosCore.alibrary wasbuilt. This update fixes this issue.
Signed-off-by: Haipeng Lin linhaipeng@pku.edu.cn