Throw a CMake error if FAST-JX is used for any KPP mechanism except Hg #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit informs the GCHP superproject about the following commits that were pushed to the GitHub geoschem/geos-chem repository: 8554d3a30 Merge PR #2363 (Update setCommonRunSettings.sh.template) This PR implements a hotfix for an issue where GCHP simulations always "thought" that they were using mass fluxes regardless of the met field option chosen. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
This commit informs the GCHP superproject about the following commits that were pushed to the GitHub geoschem/geos-chem repository: f78052f59 Merge PR #2342 (Read number of levels with clouds into Cloud-J) and to the geoschem/Cloud-J repository: 2d75997 Merge pull request #17 from geoschem/feature/set_levels_with_cloud_from_parent_model 8a3b925 Update .zenodo.json; add license badge to README d93a5aa Add Zenodo file for DOI generation 42b31ea Update version and add release date for 7.7.1 c9cbe9a Update README.md These PRs allow you to specify the number of levels with cloud for Cloud-J. This number is different depending on which instance of GEOS-Chem you are using (GCClassic, GCHP, CESM, WRF-GC, etc). Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
This commit informs the GCHP superproject about the following commits that were pushed to the GitHub geoschem/geos-chem repository: 5b3987feb Merge PR #2353 (Cloud-J error handling) And to the geoschem/Cloud-J repository: 5eabcbe Merge pull request #19 from geoschem/feature/error_handling These PRs return the error code from Cloud-J all the way out to the main program, where the simulation can be terminated gracefully. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
… fix) hflux is horizontal flux regridding. Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
This commit informs the GCHP superproject about the following commits that were pushed to the GitHub geoschem/geos-chem repository: 7e4001658 Merge PR #2369 (Fix several issues with satellite diagnostics) This PR resolves several outstanding issues with the GEOS-Chem Classic satellite diagnostics. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
src/GCHP_GridComp/GEOSChem_GridComp/CMakeLists.txt - Add an if block to throw a fatal error if the FASTJX compile option is selected for fullchem, custom, or carbon simulations. Fullchem and custom mechanisms use Cloud-J. We still need to use the FAST-JX photolysis scheme with Hg pending input file updates. CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
yantosca
added
category: Feature Request
|
All GCHP integration tests passed: ==============================================================================
GCHP: Execution Test Results
GCHP #8f8add6 Merge PR #426 (Throw error if FAST-JX is used w/ non-Hg mechanisms)
GEOS-Chem #03287a67a Merge PR #2372 (Turn off MEGAN extension for non-benchmark sims)
HEMCO #
Number of execution tests: 11
Submitted as SLURM job: 39695708
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%Also, all tests were zero-diff w/r/t PR geoschem/geos-chem#2372. |
|
See review of geoschem/GCClassic#62. I will review this PR once those comments are addressed. |
|
All GEOS-Chem Classic integration tests passed: ==============================================================================
GEOS-Chem Classic: Execution Test Results
GCClassic #8c9d395 Updated CHANGELOG.md for clarity
GEOS-Chem #011885098 Change logic in FAST-JX error trap in gc_environment_mod.F90
HEMCO #2192e0e HEMCO 3.9.1 release
Using 24 OpenMP threads
Number of execution tests: 28
Submitted as SLURM job: 40086888
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%All tests were zero-diff with the previous PR #2372, except:
|
|
All GCHP integration tests passed: ==============================================================================
GCHP: Execution Test Results
GCHP #8f8add6 Merge PR #426 (Throw error if FAST-JX is used w/ non-Hg mechanisms)
GEOS-Chem #011885098 Change logic in FAST-JX error trap in gc_environment_mod.F90
HEMCO #
Number of execution tests: 11
Submitted as SLURM job: 40087031
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%All tests were zero-diff w/r/t the previous PR #2372. |
1 similar comment
|
All GCHP integration tests passed: ==============================================================================
GCHP: Execution Test Results
GCHP #8f8add6 Merge PR #426 (Throw error if FAST-JX is used w/ non-Hg mechanisms)
GEOS-Chem #011885098 Change logic in FAST-JX error trap in gc_environment_mod.F90
HEMCO #
Number of execution tests: 11
Submitted as SLURM job: 40087031
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%All tests were zero-diff w/r/t the previous PR #2372. |
lizziel
approved these changes
Jul 16, 2024
yantosca
added a commit
that referenced
this pull request
Jul 16, 2024
This merge brings PR #426 (Throw a CMake error if FAST-JX is used for any KPP mechanism except Hg, by @yantosca) into the GCClassic "no-diff-to-benchmark" development stream. This PR adds an error trap that should prevent users of fullchem and custom simulations from selecting the FAST-JX compile time option. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Bob Yantosca
Institution: Harvard + GCST
Describe the update
This PR adds an error trap that causes CMake to throw an error if the FASTJX compile option is selected for any mechanism except Hg.
Expected changes
Configuring with the
-DFASTJX=yoption now throws an error message such as:Related Github Issue