Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw a CMake error if FAST-JX is used for any KPP mechanism except Hg #426

Closed
wants to merge 7 commits into from
14 changes: 9 additions & 5 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,18 @@
# Changelog

This file documents all notable changes to the GCHP wrapper repository starting in version 14.0.0. See also CHANGELOG files for individual submodules, such as:
- src/GCHP_GridComp/GEOSChem_GridComp/geos-chem/CHANGELOG.md
- src/GCHP_GridComp/GEOSChem_GridComp/HEMCO/CHANGELOG.md
- src/GCHP_GridComp/GEOSChem_GridComp/Cloud-J/CHANGELOG.md
- src/GCHP_GridComp/GEOSChem_GridComp/HETP/CHANGELOG.md
- src/MAPL/CHANGELOG.md
- `src/GCHP_GridComp/GEOSChem_GridComp/geos-chem/CHANGELOG.md`
- `src/GCHP_GridComp/GEOSChem_GridComp/HEMCO/CHANGELOG.md`
- `src/GCHP_GridComp/GEOSChem_GridComp/Cloud-J/CHANGELOG.md`
- `src/GCHP_GridComp/GEOSChem_GridComp/HETP/CHANGELOG.md`
- `src/MAPL/CHANGELOG.md`

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased] - TBD
### Changed
- CMake now throws an error if FAST-JX is used with any other mechanism than Hg

## [14.4.1] - 2024-06-28
### Fixed
- Fixed formatting error in `.github/workflows/stale.yml` that caused the Mark Stale Issues action not to run
Expand Down
8 changes: 8 additions & 0 deletions src/GCHP_GridComp/GEOSChem_GridComp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -147,3 +147,11 @@ gc_pretty_print(VARIABLE RRTMG IS_BOOLEAN)
gc_pretty_print(VARIABLE GTMM IS_BOOLEAN)
gc_pretty_print(VARIABLE LUO_WETDEP IS_BOOLEAN)
gc_pretty_print(VARIABLE FASTJX IS_BOOLEAN)

# Throw an error unless we are using the Hg mechanism,
# The fullchem & custom mechanisms now use Cloud-J!
if(${FASTJX})
if(NOT ${MECH} MATCHES "Hg")
message(FATAL_ERROR "FASTJX can only be used with the Hg mechanism!")
endif()
endif()
2 changes: 1 addition & 1 deletion src/GCHP_GridComp/GEOSChem_GridComp/geos-chem
Submodule geos-chem updated 38 files
+22 −0 CHANGELOG.md
+15 −3 GeosCore/cldj_interface_mod.F90
+6 −3 GeosCore/diagnostics_mod.F90
+2 −2 GeosCore/hco_interface_gc_mod.F90
+18 −1 GeosCore/input_mod.F90
+15 −6 GeosCore/photolysis_mod.F90
+0 −14 GeosCore/ucx_mod.F90
+19 −17 Headers/input_opt_mod.F90
+8 −4 Headers/state_grid_mod.F90
+13 −0 History/history_mod.F90
+19 −14 History/history_netcdf_mod.F90
+1 −0 run/CESM/geoschem_config.yml
+2 −11 run/GCClassic/HISTORY.rc.templates/HISTORY.rc.CH4
+1 −10 run/GCClassic/HISTORY.rc.templates/HISTORY.rc.CO2
+1 −11 run/GCClassic/HISTORY.rc.templates/HISTORY.rc.Hg
+1 −10 run/GCClassic/HISTORY.rc.templates/HISTORY.rc.TransportTracers
+1 −6 run/GCClassic/HISTORY.rc.templates/HISTORY.rc.aerosol
+2 −11 run/GCClassic/HISTORY.rc.templates/HISTORY.rc.carbon
+1 −2 run/GCClassic/HISTORY.rc.templates/HISTORY.rc.fullchem
+1 −11 run/GCClassic/HISTORY.rc.templates/HISTORY.rc.metals
+1 −11 run/GCClassic/HISTORY.rc.templates/HISTORY.rc.tagCO
+1 −10 run/GCClassic/HISTORY.rc.templates/HISTORY.rc.tagO3
+1 −0 run/GCClassic/geoschem_config.yml.templates/geoschem_config.yml.Hg
+1 −0 run/GCClassic/geoschem_config.yml.templates/geoschem_config.yml.aerosol
+1 −0 run/GCClassic/geoschem_config.yml.templates/geoschem_config.yml.fullchem
+1 −0 run/GCHP/geoschem_config.yml.templates/geoschem_config.yml.fullchem
+1 −1 run/GCHP/setCommonRunSettings.sh.template
+1 −0 run/GEOS/geoschem_config.yml
+1 −0 run/WRF/fullchem/geoschem_config.yml
+2 −0 run/shared/settings/geosfp/geosfp.preprocessed_ll.txt
+2 −0 run/shared/settings/geosfp/geosfp.raw_ll.txt
+2 −0 run/shared/settings/geosit/discover/geosit.raw_cs.discover.txt
+2 −0 run/shared/settings/geosit/discover/geosit.raw_ll.discover.txt
+2 −0 run/shared/settings/geosit/geosit.preprocessed_ll.txt
+2 −0 run/shared/settings/geosit/geosit.raw_cs.txt
+2 −0 run/shared/settings/geosit/geosit.raw_ll.txt
+2 −0 run/shared/settings/merra2.txt
+2 −0 run/shared/settings/modele2.1.txt
Loading