[FEATURE REQUEST] Pass rundir name not full path when determining executable name in integration tests #2083
Assignees
Labels
no-diff-to-benchmark
This update will not change the results of fullchem benchmark simulations
topic: Benchmarking and Testing
Related to CI, integration tests, or scientific benchmarking
Comments
lizziel
added
topic: Benchmarking and Testing
lizziel
changed the title
yantosca
added a commit
that referenced
this issue
Dec 20, 2023
This commit fixes the issue raised in PR #2083 by @lizziel. Integration and parallel test execute scripts now use the run directory name and not the absolute path to determine the executable file name. test/integration/GCClassic/integrationTestExecute.sh test/integration/GCHP/integrationTestExecute.sh test/parallel/GCClassic/parallelTestExecute.sh - Pass ${runDir} instead of ${runAbsPath} to the exe_name function. This will prevent integration test root paths with e.g. "rrtmg" from returning an incorrect executable name. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
1 task
1 task
yantosca
added a commit
that referenced
this issue
Dec 21, 2023
This merge brings PR #2084 (Use rundir (not absolute path) to select the executable file for integration and parallel tests, by @yantosca) into the GEOS-Chem "no-diff-to-benchmark" development stream. This PR fixes the issue reported in #2083 by @lizziel. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
|
@lizziel, feel free to close this issue. It's been merged into the no-diff-to-benchmark branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Name and Institution (Required)
Name: Lizzie Lundgren
Institution: Harvard University
New GEOS-Chem feature or discussion
During testing I noticed that RRTMG executables were being used within all integration test run directories. I traced the problem to having "rrtmg" in my test directory path. The absolute path is passed to integration function exe_name within the GCClassic and GCHP
integrationTestExecute.shscripts (see here and here). Changing this to use run directory name rather than full path will make the integration tester more robust.The text was updated successfully, but these errors were encountered: