Use rundir (not absolute path) to select the executable file for integration and parallel tests #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the issue raised in PR #2083 by @lizziel. Integration and parallel test execute scripts now use the run directory name and not the absolute path to determine the executable file name. test/integration/GCClassic/integrationTestExecute.sh test/integration/GCHP/integrationTestExecute.sh test/parallel/GCClassic/parallelTestExecute.sh - Pass ${runDir} instead of ${runAbsPath} to the exe_name function. This will prevent integration test root paths with e.g. "rrtmg" from returning an incorrect executable name. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
CHANGELOG.md - Added note that we now use the run directory and not the absolute path to determine the executable file to use in integration and parallel tests. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
yantosca
added
topic: Benchmarking and Testing
|
All GEOS-Chem Classic integration tests passed (except for TOMAS) ==============================================================================
GEOS-Chem Classic: Execution Test Results
GCClassic #8774cc3 GEOS-Chem submod update: Reduce timers to essential list only
GEOS-Chem #be203a9d9 Merge PR #2084 (Use rundir to generate executable file name in tests)
HEMCO #a5d5169 HEMCO 3.7.2 release
Using 24 OpenMP threads
Number of execution tests: 27
Submitted as SLURM job: 13227852
==============================================================================
Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 25
Execution tests failed: 2
Execution tests not yet completed: 0Also all GCClassic integration tests were identical to PR #2058, except for:
|
|
All GCHP integration tests passed: ==============================================================================
GCHP: Execution Test Results
GCHP #4774e4b GEOS-Chem submod update: Merge PR #2058 (TransportTracers in GEOS)
GEOS-Chem #be203a9d9 Merge PR #2084 (Use rundir to generate executable file name in tests)
HEMCO #a5d5169 HEMCO 3.7.2 release
Number of execution tests: 5
Submitted as SLURM job: 13227948
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%Furthermore, all integration tests were zero-diff w/r/t 14.2.3. |
|
Thanks @lizziel. I'll merge it in. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Bob Yantosca
Institution: Harvard + GCST
Confirm you have reviewed the following documentation
Describe the update
This is the companion PR to issue #2083. We have now updated the integration and parallel test execution scripts so that the the run directory (and not the absolute path) is passed to the function that determines the executable file name that gets copied to each run directory.
Expected changes
Previously, if the root path of the integration or parallel test had e.g. "rrtmg", then the "rrtmg" executable would be used for all integration or parallel tests. This update now prevents this from happeing.
This is a zero-diff update w/r/t the GEOS-Chem benchmarks.
Reference(s)
N/A
Related Github Issue(s)