Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rundir (not absolute path) to select the executable file for integration and parallel tests #2084

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Use rundir (not absolute path) to select the executable file for integration and parallel tests #2084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
684d8af
Bug fix: Use rundir to determine executable file name in tests
yantosca Dec 20, 2023
716de1c
Update CHANGELOG.md for integration/parallel test bugfix
yantosca Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

### Fixed
- Added missing units in comments of `KPP/fullchem/commonIncludeVars.H`
- Use run directory (not absolute path) to determine the executable file name in integration & parallel tests.

### Removed
- Reduced timers saved out to essential list used for benchmarking model performance
Expand Down
2 changes: 1 addition & 1 deletion test/integration/GCClassic/integrationTestExecute.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ for runDir in *; do
failMsg="$runDir${FILL:${#runDir}}.....${EXE_FAIL_STR}"

# Get the executable file corresponding to this run directory
exeFile=$(exe_name "gcclassic" "${runAbsPath}")
exeFile=$(exe_name "gcclassic" "${runDir}")

# Test if the executable exists
if [[ -f "${binDir}/${exeFile}" ]]; then
Expand Down
2 changes: 1 addition & 1 deletion test/integration/GCHP/integrationTestExecute.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ for runDir in *; do
failMsg="$runDir${FILL:${#runDir}}.....${EXE_FAIL_STR}"

# Get the executable file corresponding to this run directory
exeFile=$(exe_name "gchp" "${runAbsPath}")
exeFile=$(exe_name "gchp" "${runDir}")

# Test if the executable exists
if [[ -f "${binDir}/${exeFile}" ]]; then
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/GCClassic/parallelTestExecute.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ for runDir in *; do
failMsg="$runDir${FILL:${#runDir}}.....${EXE_FAIL_STR}"

# Get the executable file corresponding to this run directory
exeFile=$(exe_name "gcclassic" "${runAbsPath}")
exeFile=$(exe_name "gcclassic" "${runDir}")

# Test if the executable exists
if [[ -f "${binDir}/${exeFile}" ]]; then
Expand Down