-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment back in Ca, Mg, and K cations in aerosol thermodynamics #2391
Comments
@msulprizio you beat me to creating this. I discussed this issue with @beckyalexander and I volunteered to make the update. I can put it into 14.5.0. |
@msulprizio @lizziel @beckyalexander: The benchmark plots are available at @msulprizio @lizziel @beckyalexander: The link above was for 14.4.2 vs. 14.5.0-alpha.2. Please use this link below, which shows 14.5.0-alpha.1 vs 14.5.0-alpha.2: |
This has been addressed by #2398 |
@beckyalexander and I found a potential mass-balance issue in this implementation. To account for the missing Ca, Mg, and K, the Na-to-seasalt mass ratio was artificially increased from 0.3061 (i.e., seawater average) to 0.397 in previous versions. Since we are re-introducing Ca, Mg, and K to the model now, we should adjust the Na-to-SS mass ratio from 0.397 back to 0.3061. Otherwise, we would get excess amount of cations in the model. |
Thanks for reporting this. Can you confirm this is the code that is affected? geos-chem/GeosCore/aerosol_thermodynamics_mod.F90 Lines 639 to 646 in bef56c6
Also please confirm the fix is as follows:
Note that the equations are different in other ways than the scale factor. Please let us know what the correct equation should be. |
@yc-chan, @beckyalexander - We plan to freeze 14.5.0 in the next few days and begin benchmarking. Please let us know exactly what the fix is as soon as possible to ensure it gets into this version. Otherwise it will need to wait for 14.6.0. |
I think you should change the value of 0.397 to 0.3061. There are other differences in the two equations (such as the use of the AlkR variable). All we want to change right now is the mass fraction of Na in sea salt. This equation is for fine-mode sea salt. I also think line 658 needs to be changed, which deals with coarse-mode sea salt aerosol. The current value is 0.378. I don't know why these values are different for fine and coarse mode. They should both be 0.3061, which is the dry mass fraction of sea salt. |
@beckyalexander and I discovered another issue as we are testing the new code. In the past, GC only called ISORROPIA for doing fine-mode-aerosol calculations, so it assumed all the Ca, Mg, and K in aerosols are from fine-mode seasalt. However, DO_ATE is now also used for coarse-mode-aerosol calculations so we have to update the code for that. In short, we should replace this block:
with something like this:
Note that the alkalinity factor AlkR is now included in the formula for TCA, TK, and TMG to make sure they are treated the same way as TNA. Without this fix, I expect that GC would underestimate cation abundance in coarse-mode aerosols over the marine boundary layer, especially after the previous correction to Na-to-seasalt mass ratio. |
Thanks for reporting this @yc-chan @beckyalexander. We are about to begin benchmarking for version 14.5.0 this week. If you could please submit a pull request with this fix we can try to get it into this version. Another option would be to implement a fix in 14.6.0 when these updates have been better evaluated. Please let us know how to proceed as we don't want to delay release of 14.5.0 much longer. |
I just submitted a PR. I don't have a strong opinion on whether the fix should be merged in 14.5.0 or 14.6.0. Tag @beckyalexander to weigh in. |
Thanks @yc-chan. This latest PR has now been merged into the 14.5.0 development branch. We will proceed with benchmarking that version in preparation for release. |
Your name
Melissa Sulprizio
Your affiliation
Harvard
Provide a clear and concise overview of the new feature requested.
These species are commented out in ISORROPIA and HETP and should be uncommented.
Tagging @beckyalexander for more details and a better estimate of delivery timeframe.
Reference(s)
No response
Will you be implementing this feature yourself?
No
Additional information
No response
The text was updated successfully, but these errors were encountered: