-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass non-zero Ca2, Mg, and K cations to HETP #2398
Conversation
Previously these values were zero due to an issue in ISORROPIA. With the update to HETP we can now enable these cations. Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
3786731
to
0276c54
Compare
All integration tests pass for both GC-Classic and GCHP. |
Tagging Aerosols WG Co-chairs: @beckyalexander, @theloniuspunk, @wporter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lizziel. This looks OK to merge. I'll start testing this.
@lizziel: I've merged this into dev/14.5.0 (locally) and am running integration tests. |
All GEOS-Chem Classic integration tests passed: ==============================================================================
GEOS-Chem Classic: Execution Test Results
GCClassic #96e3b6b Hotfix: Point to dev/14.5.0 + 14.4.2 in src/GEOS-Chem
GEOS-Chem #e29a4c928 Merge PR #2398 (Pass non-zero Ca2, Mg, and K cations to HETP)
HEMCO #e68ebae HEMCO 3.9.2 release
Using 24 OpenMP threads
Number of execution tests: 28
Submitted as SLURM job: 41377041
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% |
All GCHP integration tests passed: ==============================================================================
GCHP: Execution Test Results
GCHP #ce7df31 Merge GCHP 14.4.2 back into the 14.5.0 development stream
GEOS-Chem #e29a4c928 Merge PR #2398 (Pass non-zero Ca2, Mg, and K cations to HETP)
HEMCO #
Number of execution tests: 11
Submitted as SLURM job: 41377765
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% |
@beckyalexander, difference plots which isolate this update are now available to view. Could you take a look and verify changes are as you expect? @beckyalexander: The previous benchmark was w/r/t 14.4.2 instead of 14.5.0-alpha.1. Use this link instead: |
Name and Institution (Required)
Name: Lizzie Lundgren
Institution: Harvard University
Describe the update
This PR uncomments setting Ca2+, K+, and Mg+ cation values passed to HETP. Previously these values were zero due to an issue in ISORROPIA. With the update to HETP we can enable these cations.
Expected changes
This update will change benchmark results.
Reference(s)
None
Related Github Issue
closes #2391