-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fixes for ALK4 and R4N2 chemistry from Brewer et al. (2023, JGR) #2352
Conversation
R4N2 was a common product of alkane, isoprene, and monoterpene oxidation and produced organonitrate SOA but we don’t want ALK4 to produce organonitrate SOA as discusses in #1625. A fix from Jared Brewer is included here. NOTE: The KPP fullchem mechanism has not been rebuilt with these fixes to facilitate merging these updates up to the latest GEOS-Chem release. These updates will also need to be added to the custom.eqn file. Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @msulprizio. I think this is OK to merge. I can add the updates to custom.eqn as a post-merge update. We'd also need to update KPP/fullchem/CHANGELOG_fullchem.md
.
Hi @JFBrewer and @kelvinhb. I am merging these updates (based off of 14.1.0) with the latest version (branch Could you help me figure out if the fixes from Brewer2023 are still needed on top of the Bates2023 updates? If so, could you provide guidance on how to resolve the conflicts below? Also tagging Chemistry Working Group Chairs @barronh and @luhu0 for awareness.
|
Hi team, My understanding of Jared's update is that it creates a new duplicate set of some ALK4-type species that are functionally identical to what's already in there (as in, all the same reactions are duplicated) but they allow us to keep separate some of the products that were previously made both from biogenic and anthropogenic sources. The problem arises in that, in the JPL/IUPAC updates, we've modified product yields in a lot of those reactions that Jared duplicates to better conserve carbon -- most of them were out of whack because of rounding errors or misinterpretations in how much carbon is contained in the generic "R" species (RCHO, R4P, etc). I think the goal here should be to have the duplicated reactions match the JPL/IUPAC updated ones. If that sounds alright to everyone, I can go through and pick out which reactions have changed and modify those branching ratios in Jared's updates -- unless anyone thinks we should do this some other way? Also, it looks like these updates use the same photolysis reference numbers -- e.g. the photolysis reactions for R4P + hv and ALK4P + hv both have the rate "PHOTOL(83)". Does the code to calculate photolysis rates interpret that correctly? If so it seems like there's a lot of simplification we can do in the photolysis section, since tons of those reactions have effectively the same rate coefficients.... -Kelvin |
Thanks for the feedback @kelvinhb. Based on your comments, I can make a first pass at combining Jared's updates with the latest JPL/IUPAC rates already used in the latest version. I will also have a look at the photolysis reference numbers and get back to you all. |
Resolved conflicts in: CHANGELOG.md KPP/fullchem/fullchem.eqn KPP/fullchem/fullchem.kpp run/shared/species_database.yml Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
@kelvinhb @JFBrewer I have merged the ALK4 and R4N2 chemistry updates up to the latest Note that the following reactions in Jared's original updates have been removed:
This is because the following reactions were removed from #1765:
I am now running a 1-month benchmark locally to test these updates and will post a summary here before merging into 14.5.0. |
Hi @JFBrewer @kelvinhb. I ran a 1-month benchmark simulation to evaluate the impact from these updates. The plots are available here. Could you review these changes and confirm that they are consistent with the expected changes? Once we get your OK we can merge this into From a quick glance, the changes appear to be very small. Global mean OH changes by -0.000056%. ALK4 and R4N2 increase slightly (0.000034% and 0.000217%, respectively). See these quick links below for details: |
Yes, this makes sense to me. I agree with Kevin's statements above. The goal of my changes was to not change much about the underlying chemistry but to make certain that anthropogenic emissions weren't leading to the creation of primarily biogenic tracers in a non-physical way. In most places this didn't make a major difference but it did matter over regions like Korea with low biogenic and high anthropogenic emissions. |
Thanks for confirming @JFBrewer! |
Thanks @msulprizio and @JFBrewer! I'll start testing and merging this into 14.5.0. |
After merging (locally) into dev/14.5.0, all GEOS-Chem Classic integration tests pass: ==============================================================================
GEOS-Chem Classic: Execution Test Results
GCClassic #6f22240 GEOS-Chem submod update: Merge PR #2398 (Uncomment cations for HETP)
GEOS-Chem #0a392d465 Merge PR #2352 (Fixes for ALK4 and R4N2 chemistry from J. Brewer)
HEMCO #e68ebae HEMCO 3.9.2 release
Using 24 OpenMP threads
Number of execution tests: 28
Submitted as SLURM job: 42182865
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% |
After merging locally into dev/14.5.0, all GCHP integration tests passed: ==============================================================================
GCHP: Execution Test Results
GCHP #136fa70 GEOS-Chem submod update: Merge PR #2398 (Uncomment cations for HETP)
GEOS-Chem #0a392d465 Merge PR #2352 (Fixes for ALK4 and R4N2 chemistry from J. Brewer)
HEMCO #
Number of execution tests: 11
Submitted as SLURM job: 42182917
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% |
Due to an oversight, we had forgotten to rebuild the KPP solver files for PR #2352. This has now been done. We will re-tag this PR with 14.5.0-alpha.4 to re-trigger 1-month benchmarks. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Name and Institution (Required)
Name: Melissa Sulprizio
Institution: Harvard
Describe the update
I am opening this pull request on behalf of @JFBrewer.
R4N2 was a common product of alkane, isoprene, and monoterpene oxidation and produced organonitrate SOA but we don’t want ALK4 to produce organonitrate SOA as discusses in #1625. A fix from Jared Brewer is included here.
NOTE: These updates are made off of 14.1.0. The KPP fullchem mechanism has not been rebuilt with these fixes to facilitate merging these updates up to the latest GEOS-Chem release. These updates will also need to be added to the custom.eqn file.
Expected changes
We expect decreases in R4O2 and increases in ACET, MEK, HO2, ALD2, RCHO, MEK, CH2O, NO2 and other species due to the changing chemical mechanism.
Reference(s)
Related Github Issue