Fixed the problem that GCHP cannot read meteorology field from yaml #2675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yantosca
requested changes
Jan 9, 2025
There was a problem hiding this comment.
Looks good @yuanjianz, we would just need a CHANGELOG.md update.
yantosca
added
topic: GCHP
|
I believe this fixes an issue brought in with the updates for GEOS-IT in dev/no-diff-to-benchmark (see #2523). It would only show up for GEOS-FP and GEOS-IT runs which we do not test in integration/AWS testing, and is not in any previously released versions. It therefore does not need an update to the changelog. |
yantosca
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Yuanjian Zhang
Institution: WashU
Describe the update
Fixed the problem that GCHP cannot read meteorology field from yaml