Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix convection issues when meteorology is Grell Freitas scheme #2523

Conversation

yuanjianz
Copy link
Contributor

@yuanjianz yuanjianz commented Oct 16, 2024

Name and Institution (Required)

Yuanjian Zhang (WashU), Lizzie Lundgren (Harvard)

Describe the update

See discussion #1409

GEOS-IT and GEOS-FP after Jun 2020 switch to Grell Freitas convection from RAS. Some meteorology field definitions are changed. This update accommodates these fields to geos-chem convection.

Reported by @viral211 first:

There was an error in archiving the convective precipitation fields (PFLCU and PFICU) in our GEOS-IT and GEOS-FP data after the switch to Grell-Freitas (the fields are just set to zero). These fields are used in GEOS-Chem to calculate convective washout and re-evaporation

@yuanjianz:

Since DQRCU by definition is changed to net precipitation (MERRA-2 definition DQRCU minus layer-wise re-evaporation), do you think we should add layer-wise REEVAP back to match the DQRCU for determining cloud base height? It may lower the cloud base height somehow, given it seems some gas tracer is substantially below observation constraint?

Changes include:

  1. Add surface precipitation flux fields as inputs to GCHP.
  2. Add meteorology source name to GCHP run directory geoschem_config.yml
  3. Create new Input_Opt logical for whether to reconstruct convective precipitation flux. This switch is set automatically during run-time to true for GEOS-IT, true for GEOS-FP if start date is June 1 2020 or later, and false for all other cases.
  4. Use the new Input_Opt logical to use an alternative method in convection which bypasses use of PFLCU and PFICU when necessary. This fixes the zero convective precipitation and high cloud base in runs using GEOS-FP (>=01Jun2020) or GEOS-IT.
  5. Add a warning during run directory creation about the convection scheme change and the precipitation flux bug (only if selecting GEOS-FP meteorology). This warning stops run directory creation and requires acknowledgement from the user to continue.

Related convection fixes are also applicable to simulations using met-fields generated with RAS. These are submitted via separate PR #2573. Those updates will impact the GEOS-Chem benchmark.

Expected changes

Lower cloud base and restored washout in geos-chem convection driven by GEOS-IT and GEOS-FP after Jun 2020. This will not affect the GEOS-Chem benchmark which uses MERRA2.

Related Github Issue

#2469

@yuanjianz yuanjianz changed the title Fix convections issues when meteorology is Grell Freitas scheme Fix convection issues when meteorology is Grell Freitas scheme Oct 16, 2024
@yantosca yantosca added category: Bug Fix Fixes a previously-reported bug topic: Convection and Mixing Related to cloud convection and PBL mixing labels Oct 17, 2024
@yuanjianz yuanjianz force-pushed the bugfix/Grell_Friedas_convection branch from d130988 to 255a58d Compare November 15, 2024 17:09
@yuanjianz yuanjianz marked this pull request as ready for review November 15, 2024 19:45
@lizziel
Copy link
Contributor

lizziel commented Nov 19, 2024

I updated the PR description to include my contributions submitted via yuanjianz#1.

@lizziel lizziel added this to the 14.5.1 milestone Nov 19, 2024
@lizziel lizziel requested a review from yantosca November 19, 2024 21:29
@yantosca yantosca changed the base branch from main to dev/no-diff-to-benchmark November 21, 2024 20:32
@lizziel lizziel self-assigned this Nov 22, 2024
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lizziel, thanks for the PR. I just caught a couple of typos in the warning messages in the rundir creation scripts. Otherwise looks good to go!

run/GCClassic/createRunDir.sh Outdated Show resolved Hide resolved
run/GCHP/createRunDir.sh Outdated Show resolved Hide resolved
@yuanjianz yuanjianz requested a review from yantosca December 3, 2024 23:54
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lizziel and @yuanjianz! Good to merge.

@lizziel
Copy link
Contributor

lizziel commented Dec 4, 2024

Great, I'll bring this in along with the GCHPctmEnv fixes PR.

yuanjianz and others added 11 commits December 5, 2024 10:46
…eld definition change in Grell-Freitas convection
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
@lizziel lizziel force-pushed the bugfix/Grell_Friedas_convection branch from 81c5b34 to cee694d Compare December 5, 2024 15:47
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
@lizziel lizziel merged commit 4bcc43e into geoschem:dev/no-diff-to-benchmark Dec 5, 2024
yantosca added a commit that referenced this pull request Jan 9, 2025
This merge brings PR #2675 (Fixed the problem that GCHP cannot read
meteorology field from yaml, by @yantosca) into the GEOS-Chem
"no-diff-to-benchmark" development stream.

According to @lizziel:

  I believe this fixes an issue brought in with the updates for
  GEOS-IT in dev/no-diff-to-benchmark (see PR #2523). It would only
  show up for GEOS-FP and GEOS-IT runs which we do not test in
  integration/AWS testing, and is not in any previously released
  versions. It therefore does not need an update to the changelog.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Fix Fixes a previously-reported bug topic: Convection and Mixing Related to cloud convection and PBL mixing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants