Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates related to Grell Friedas convection fix #1

Conversation

lizziel
Copy link

@lizziel lizziel commented Nov 14, 2024

Name and Institution (Required)

Name: Lizzie Lundgren
Institution: Harvard University

Describe the update

  1. Added meteorology source name to GCHP run directory geoschem_config.yml
  2. Created new Input_Opt logical for whether to reconstruct convective precipitation flux. This switch is set automatically during run-time to true for GEOS-IT, true for GEOS-FP if start date is June 1 2020 or later, and false for all other cases.
  3. Used the new Input_Opt logical to tap into the code @yuanjianz implemented in this branch already.
  4. Added a warning during run directory creation about the convection scheme change and the precipitation flux bug (only if selecting GEOS-FP meteorology). This warning stops run directory creation and requires acknowledgement from the user to continue.
  5. Updated change log for updates by both me and @yuanjianz.

Expected changes

I will update the main PR description after merge to reflect that me and Viral as contributors and further describe the updates.

Related Github Issue

These changes are the implementation agreed upon in geoschem#2469.

Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
@yuanjianz yuanjianz merged commit d130988 into yuanjianz:bugfix/Grell_Friedas_convection Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants