Fixes #1645: custom connect to be used in plugins definition; propert… #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nition; properties in pluginCfg override state connected properties
offtherailz
reviewed
Mar 28, 2017
| @@ -122,6 +124,11 @@ const getReducers = (plugins) => Object.keys(plugins).map((name) => plugins[name | |||
| const getEpics = (plugins) => Object.keys(plugins).map((name) => plugins[name].epics) | |||
| .reduce((previous, current) => assign({}, previous, current), {}); | |||
|
|
|||
| const pluginsMergeProps = (stateProps, dispatchProps, ownProps) => { | |||
| const {pluginCfg, ...otherProps} = ownProps; | |||
| return assign({}, otherProps, stateProps, dispatchProps, pluginCfg || {}); | |||
There was a problem hiding this comment.
Didn't understand how to configure it.
pluginsCfg always wins over stateProps.
Could it be that pluginsCfg can be overridden by stateProps? Or do you mean that all the other Props are overridable while pluginCfg is the way to set fixed config.
can you document it?
There was a problem hiding this comment.
pluginCfg is the way to set fixed config, but plugins cfg can be dynamic, using expressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ies in pluginCfg override state connected properties