Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translations of parsers error messages #923

Closed
slafayIGN opened this issue Jun 10, 2024 · 1 comment
Closed

Translations of parsers error messages #923

slafayIGN opened this issue Jun 10, 2024 · 1 comment

Comments

@slafayIGN
Copy link

slafayIGN commented Jun 10, 2024 •
edited
Loading

Messages from the parsers are in english.

For instance : https://github.com/geostyler/geostyler-sld-parser/blob/master/src/SldStyleParser.ts#L976

   throw new Error('MarkSymbolizer cannot be parsed. Unsupported WellKnownName.');

These messages sometimes have to be displayed for the end user who may be using a UI in another language. It would be great to make the parsers more multilingual.

In addition, the message may contain the "Unsupported WellKnownName". (see #924)
@slafayIGN slafayIGN converted this from a draft issue Jun 10, 2024
ocruze added a commit that referenced this issue Jun 19, 2024
@ocruze
feat: implement i18n for error messages #923 #924
dd82bfa
jansule pushed a commit that referenced this issue Jun 21, 2024
@ocruze
feat: implement i18n for error messages #923 #924 (#928)
e01c8c8 
* feat: implement i18n for error messages #923 #924

* feat: add translations in French

* fix: change typings as suggested in review

* fix: change French translations
@ocruze
Copy link
Member

ocruze commented Jun 21, 2024

Done in #928

@ocruze ocruze closed this as completed Jun 21, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in CodeSprint 2024 Jun 21, 2024
github-actions bot pushed a commit that referenced this issue Jun 21, 2024
@semantic-release-bot
chore(release): 5.4.0 [skip ci]
be49cd7 
## [5.4.0](v5.3.1...v5.4.0) (2024-06-21)

### Features

* Extract SLD version from SLD ([#926](#926)) ([56f231b](56f231b))
* implement i18n for error messages [#923](#923) [#924](#924) ([#928](#928)) ([e01c8c8](e01c8c8))

### Bug Fixes

* offset Y for Textsymbolizer ([#932](#932)) ([398ce0c](398ce0c)), closes [#566](#566)
ocruze added a commit that referenced this issue Jul 3, 2024
@ocruze
feat: reimplementing i18n for error messages without i18next #923 #924 …
fab9232 
…#928
ocruze added a commit that referenced this issue Jul 3, 2024
@ocruze
feat: reimplementing i18n for error messages without i18next #923 #924 …
48a1cce 
…#928 #944
ocruze added a commit that referenced this issue Jul 3, 2024
@ocruze
feat: reimplementing i18n for error messages without i18next #923 #924 …
e69facc 
…#928 #944
ocruze added a commit that referenced this issue Jul 3, 2024
@ocruze
feat: reimplementing i18n for error messages without i18next #923 #924 …
6f304ff 
…#928 #944
ocruze added a commit that referenced this issue Jul 3, 2024
@ocruze
feat: reimplementing i18n for error messages without i18next #923 #924 …
8252180 
…#928 #944
hwbllmnn added a commit that referenced this issue Jul 4, 2024
@hwbllmnn
Merge pull request #946 from geostyler/i18n-reimplementation
8751784 
feat: reimplementing i18n for error messages without i18next #923 #924 #928 #944
github-actions bot pushed a commit that referenced this issue Jul 4, 2024
@semantic-release-bot
chore(release): 6.1.0 [skip ci]
944ac93 
## [6.1.0](v6.0.0...v6.1.0) (2024-07-04)

### Features

* reimplementing i18n for error messages without i18next [#923](#923) [#924](#924) [#928](#928) [#944](#944) ([8252180](8252180))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
CodeSprint 2024
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@slafayIGN @ocruze