-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SLD parser causes i18next issue in projects that use i18next #944
Comments
I am a bit surprised. Why does a parser need |
This was added during the codesprint in Paris to enable localized error messages, which in principle I like. I was also surprised that |
I suggested @ocruze to use i18next. He started with a different library but i told him that we use i18next elsewhere and it works well... 🤦♂️ |
Actually initially I didn't use any library at all, it was pure ts types. Maybe I can make another proposal with ts types and you can revert my PR? |
Yeah this would be great. I'm afraid that this is kind of blocking the release of geostyler / geostyler-demo. |
I think this is solved with #946 |
Bug
Describe the bug
The initialization of i18next in the parser causes the initialization in downstream projects to fail. If using e.g. the fetch backend will not run (will not fetch the i18n files) in case the initialization in the SLD parser runs first.
To Reproduce
Steps to reproduce the behavior:
Embed the SLD parser in a project that also uses i18next (or react-i18next).
Expected behavior
I'd expect the i18next usage in the SLD parser not to influence the usage in downstream projects.
Desktop (please complete the following information):
Happens in all browsers.
Additional context
The initialization of i18next should probably be managed by configuration or by construction option. Perhaps a i18next configuration module could be created that can be used by downstream projects.
The text was updated successfully, but these errors were encountered: