feat: implement i18n for error messages #923 #924 #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaiVolland
reviewed
Jun 19, 2024
There was a problem hiding this comment.
Nice job @ocruze. I added some notes to limitations the typings would introduce.
slafayIGN
reviewed
Jun 19, 2024
src/SldStyleParser.ts
Outdated
| de: {}, | ||
| fr: { | ||
| marksymbolizerParseFailedUnknownWellknownName: | ||
| 'Lecture de MarkSymbolizer échoué. Le WellKnownName {{wellKnownName}} n\'est pas supporté.', |
There was a problem hiding this comment.
Échec de lecture du symbole de type MarkSymbolizer. Le WellKnownName...
slafayIGN
reviewed
Jun 19, 2024
src/SldStyleParser.ts
Outdated
| marksymbolizerParseFailedUnknownWellknownName: | ||
| 'Lecture de MarkSymbolizer échoué. Le WellKnownName {{wellKnownName}} n\'est pas supporté.', | ||
| noFilterDetected: 'Aucun filtre détecté.', | ||
| symbolizerKindParseFailed: 'Lecture de SymbolizerKind {{sldSymbolizerName}} à partir de SldRule échoué.', |
There was a problem hiding this comment.
Échec de lecture du type de symbole {{sldSymbolizerName}} à partir de SldRule.
slafayIGN
reviewed
Jun 19, 2024
| 'Lecture de MarkSymbolizer échoué. Le WellKnownName {{wellKnownName}} n\'est pas supporté.', | ||
| noFilterDetected: 'Aucun filtre détecté.', | ||
| symbolizerKindParseFailed: 'Lecture de SymbolizerKind {{sldSymbolizerName}} à partir de SldRule échoué.', | ||
| colorMapEntriesParseFailedColorUndefined: 'Lecture de ColorMapEntries échoué. color n\'est pas défini.', |
There was a problem hiding this comment.
Échec de lecture des couleurs ColorMapEntries : color n'est pas défini.
slafayIGN
requested changes
Jun 19, 2024
src/SldStyleParser.ts
Outdated
| symbolizerKindParseFailed: 'Lecture de SymbolizerKind {{sldSymbolizerName}} à partir de SldRule échoué.', | ||
| colorMapEntriesParseFailedColorUndefined: 'Lecture de ColorMapEntries échoué. color n\'est pas défini.', | ||
| contrastEnhancParseFailedHistoAndNormalizeMutuallyExclusive: | ||
| 'Lecture de ContrastEnhancement échoué. Histogram et Normalize sont mutuellement exclusifs.', |
There was a problem hiding this comment.
Échec de lecture des propriétés de contraste ContrastEnhancement. Histogram....
src/SldStyleParser.ts
Outdated
| contrastEnhancParseFailedHistoAndNormalizeMutuallyExclusive: | ||
| 'Lecture de ContrastEnhancement échoué. Histogram et Normalize sont mutuellement exclusifs.', | ||
| channelSelectionParseFailedRGBAndGrayscaleMutuallyExclusive: | ||
| 'Lecture de ChannelSelection échoué. RGB et Grayscale sont mutuellement exclusifs.', |
There was a problem hiding this comment.
Échec de lecture de la sélection de canaux ChannelSelection....
src/SldStyleParser.ts
Outdated
| channelSelectionParseFailedRGBAndGrayscaleMutuallyExclusive: | ||
| 'Lecture de ChannelSelection échoué. RGB et Grayscale sont mutuellement exclusifs.', | ||
| channelSelectionParseFailedRGBChannelsUndefined: | ||
| 'Lecture de ChannelSelection échoué. Les canaux Rouge, Vert et Bleu doivent être définis.', |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 21, 2024
## [5.4.0](v5.3.1...v5.4.0) (2024-06-21) ### Features * Extract SLD version from SLD ([#926](#926)) ([56f231b](56f231b)) * implement i18n for error messages [#923](#923) [#924](#924) ([#928](#928)) ([e01c8c8](e01c8c8)) ### Bug Fixes * offset Y for Textsymbolizer ([#932](#932)) ([398ce0c](398ce0c)), closes [#566](#566)
|
🎉 This PR is included in version 5.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ocruze
added a commit
that referenced
this pull request
Jul 3, 2024
ocruze
added a commit
that referenced
this pull request
Jul 3, 2024
ocruze
added a commit
that referenced
this pull request
Jul 3, 2024
ocruze
added a commit
that referenced
this pull request
Jul 3, 2024
ocruze
added a commit
that referenced
this pull request
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.