system.languages.session_store_active: Language never stored in, or retrieved from session

[pamtbaau]

The following setting in system.yaml is supposed to store the chosen language extension in the url into the session:

languages:
  supported: [it, en]
  session_store_active: true

However, the chosen language will never be stored in, nor retrieved from, the session, because function Language::setActiveFromUri($uri) is called before the session has been initialized.

InitializeProcessor.php
In InitializeProcessor::process(), the line $this->initializeUri($config);, which calls Language::setActiveFromUri($uri) is executed before $this->initializeSession($config);

grav/system/src/Grav/Common/Processors/InitializeProcessor.php

Lines 104 to 123 in a67a538

	// Initialize URI.
	$this->initializeUri($config);
	// Grav may return redirect response right away.
	$redirectCode = (int)$config->get('system.pages.redirect_trailing_slash', 1);
	if ($redirectCode) {
	$response = $this->handleRedirectRequest($request, $redirectCode > 300 ? $redirectCode : null);
	if ($response) {
	$this->stopTimer('_init');
	return $response;
	}
	}
	// Load accounts (decides class to be used).
	// TODO: remove in 2.0.
	$this->container['accounts'];
	// Initialize session.
	$this->initializeSession($config);

Language.php
Because of the above, the following if-statements, meant to store and retrieve the language value from the session, will always evaluate to false:

grav/system/src/Grav/Common/Language/Language.php

Lines 249 to 261 in a67a538

	// Store in session if language is different.
	if (isset($this->grav['session']) && $this->grav['session']->isStarted()
	&& $this->config->get('system.languages.session_store_active', true)
	&& $this->grav['session']->active_language != $this->active
	) {
	$this->grav['session']->active_language = $this->active;
	}
	} else {
	// Try getting language from the session, else no active.
	if (isset($this->grav['session']) && $this->grav['session']->isStarted() &&
	$this->config->get('system.languages.session_store_active', true)) {
	$this->setActive($this->grav['session']->active_language ?: null);
	}

[mahagr]

The language code should really be inside an event SessionStartEvent (class).

[mahagr]

@pamtbaau Can you test my fix? :)

[pamtbaau]

Just did and it seems to be working fine.

• Fresh install Grav 1.7.10
• system.yaml

  languages:
    supported: [de, en]
    session_store_active: true
  

• browse to 'localhost/en/typography'
• browse to 'localhost/typography' ---redirect---> localhost/en/typography
• browse to 'localhost/de/typography'
• browse to 'localhost/typography' ---redirect---> localhost/de/typography