fix session_store_active functionality
#3464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment and since 1.7.19, the `system.languages.session_store_active` setting has no effect. Session must be initialized before URI for `$language->setActiveFromUri($uri)` (called from `$this->initializeUri($config) -> $uri->init()`) to properly retrieve / store `active_language` in Session. This was previously detected in getgrav#3269 as per the code comment, but got reversed in 2e9fe80.
|
@mahagr Revisiting old PRs -- well this one is not that old but I was on a good run 😁 |
|
I have no idea why I moved it back -- I think there must be some kind of chicken-egg problem where something breaks in both cases. If that is true, we may need to change the logic a bit more. |
mahagr
added a commit
that referenced
this pull request
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment and since 1.7.19, the
system.languages.session_store_activesetting has no effect.Session must be initialized before URI for
$language->setActiveFromUri($uri)(called from$this->initializeUri($config) -> $uri->init()) to properly retrieve / storeactive_languagein Session.This was previously detected in #3269 as per the code comment, but got reversed in 2e9fe80.