Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: support multiple instance annotation for Kubernetes Automatic Service Discovery #3590

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

aldycool
Copy link
Contributor

@aldycool aldycool commented Jun 5, 2024

Proposed change

This is an added feature to allow Kubernetes Ingresses to have multiple instance annotations, so this make it possible to show a single Ingress to a selected Homepage instances. The code change is very minimal and does not introduce breaking changes, and I already update the Kubernetes configuration documentation on how to use this feature.

This is very similar to issue #2340 which solved this problem for Docker, while this PR is for Kubernetes.

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

@shamoon shamoon changed the title Support multiple instance annotation for Kubernetes Automatic Service Discovery Enhancement: support multiple instance annotation for Kubernetes Automatic Service Discovery Jun 5, 2024
@shamoon shamoon enabled auto-merge (squash) June 5, 2024 02:53
Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, if you look at our dev guidelines we technically require feature PRs to be linked to an up-voted FR but given how simple this is and the fact that its really just parity with the docker logic I think this is ok. Please do keep that in mind if you choose to contribute in the future.

@shamoon shamoon merged commit 35dd7ec into gethomepage:main Jun 5, 2024
5 checks passed
truecharts-admin referenced this pull request in truecharts/public Jun 6, 2024
…0.9.2@5356c97 by renovate (#22920)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/gethomepage/homepage](https://github.com/gethomepage/homepage)
| patch | `v0.9.1` -> `v0.9.2` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary>

###
[`v0.9.2`](https://github.com/gethomepage/homepage/releases/tag/v0.9.2)

[Compare
Source](https://github.com/gethomepage/homepage/compare/v0.9.1...v0.9.2)

#### What's Changed

#### Security

- This release addresses a vulnerability that could allow leakage of API
keys from weather widgets, see
https://github.com/gethomepage/homepage/security/advisories/GHSA-cjgf-vhj6-8cx4
. Thanks to Kwstubbs for reporting.

#### App changes

- Fix: caddy widget broken in v0.9.1 by
[@&#8203;shamoon](https://github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3579](https://github.com/gethomepage/homepage/pull/3579)
- Fix: omada widget broken in v0.9.1 by
[@&#8203;shamoon](https://github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3587](https://github.com/gethomepage/homepage/pull/3587)
- Fix/handle null id in json rpc responses and cpu load representation
for openwrt widget by [@&#8203;LiranV](https://github.com/LiranV) in
[https://github.com/gethomepage/homepage/pull/3576](https://github.com/gethomepage/homepage/pull/3576)
- Fix: wg-easy threshold not properly computed by
[@&#8203;ConnerWithAnE](https://github.com/ConnerWithAnE) in
[https://github.com/gethomepage/homepage/pull/3574](https://github.com/gethomepage/homepage/pull/3574)
- Enhancement: support multiple instance annotation for Kubernetes
Automatic Service Discovery by
[@&#8203;aldycool](https://github.com/aldycool) in
[https://github.com/gethomepage/homepage/pull/3590](https://github.com/gethomepage/homepage/pull/3590)
- Fix: coinmarketcap widget dropdown not clickable by
[@&#8203;henry40408](https://github.com/henry40408) in
[https://github.com/gethomepage/homepage/pull/3591](https://github.com/gethomepage/homepage/pull/3591)

#### New Contributors

- [@&#8203;LiranV](https://github.com/LiranV) made their first
contribution in
[https://github.com/gethomepage/homepage/pull/3576](https://github.com/gethomepage/homepage/pull/3576)
- [@&#8203;aldycool](https://github.com/aldycool) made their first
contribution in
[https://github.com/gethomepage/homepage/pull/3590](https://github.com/gethomepage/homepage/pull/3590)

**Full Changelog**:
gethomepage/homepage@v0.9.1...v0.9.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTIuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5Mi4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImF1dG9tZXJnZSIsInVwZGF0ZS9kb2NrZXIvZ2VuZXJhbC9ub24tbWFqb3IiXX0=-->
szinn referenced this pull request in szinn/k8s-homelab Jun 6, 2024
…v0.9.2 ) (#3790)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/gethomepage/homepage](https://github.com/gethomepage/homepage)
| patch | `v0.9.1` -> `v0.9.2` |

---

### Release Notes

<details>
<summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary>

###
[`v0.9.2`](https://github.com/gethomepage/homepage/releases/tag/v0.9.2)

[Compare
Source](https://github.com/gethomepage/homepage/compare/v0.9.1...v0.9.2)

#### What's Changed

#### Security

- This release addresses a vulnerability that could allow leakage of API
keys from weather widgets, see
https://github.com/gethomepage/homepage/security/advisories/GHSA-cjgf-vhj6-8cx4
. Thanks to Kwstubbs for reporting.

#### App changes

- Fix: caddy widget broken in v0.9.1 by
[@&#8203;shamoon](https://github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3579](https://github.com/gethomepage/homepage/pull/3579)
- Fix: omada widget broken in v0.9.1 by
[@&#8203;shamoon](https://github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3587](https://github.com/gethomepage/homepage/pull/3587)
- Fix/handle null id in json rpc responses and cpu load representation
for openwrt widget by [@&#8203;LiranV](https://github.com/LiranV) in
[https://github.com/gethomepage/homepage/pull/3576](https://github.com/gethomepage/homepage/pull/3576)
- Fix: wg-easy threshold not properly computed by
[@&#8203;ConnerWithAnE](https://github.com/ConnerWithAnE) in
[https://github.com/gethomepage/homepage/pull/3574](https://github.com/gethomepage/homepage/pull/3574)
- Enhancement: support multiple instance annotation for Kubernetes
Automatic Service Discovery by
[@&#8203;aldycool](https://github.com/aldycool) in
[https://github.com/gethomepage/homepage/pull/3590](https://github.com/gethomepage/homepage/pull/3590)
- Fix: coinmarketcap widget dropdown not clickable by
[@&#8203;henry40408](https://github.com/henry40408) in
[https://github.com/gethomepage/homepage/pull/3591](https://github.com/gethomepage/homepage/pull/3591)

#### New Contributors

- [@&#8203;LiranV](https://github.com/LiranV) made their first
contribution in
[https://github.com/gethomepage/homepage/pull/3576](https://github.com/gethomepage/homepage/pull/3576)
- [@&#8203;aldycool](https://github.com/aldycool) made their first
contribution in
[https://github.com/gethomepage/homepage/pull/3590](https://github.com/gethomepage/homepage/pull/3590)

**Full Changelog**:
gethomepage/homepage@v0.9.1...v0.9.2

</details>

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL3BhdGNoIl19-->

Co-authored-by: repo-jeeves[bot] <106431701+repo-jeeves[bot]@users.noreply.github.com>
spiceratops referenced this pull request in spiceratops/k8s-gitops Jun 8, 2024
…785)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/gethomepage/homepage](https://github.com/gethomepage/homepage)
| minor | `v0.8.13` -> `v0.9.2` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary>

###
[`v0.9.2`](https://github.com/gethomepage/homepage/releases/tag/v0.9.2)

[Compare
Source](https://github.com/gethomepage/homepage/compare/v0.9.1...v0.9.2)

#### What's Changed

#### Security

- This release addresses a vulnerability that could allow leakage of API
keys from weather widgets.

#### App changes

- Fix: caddy widget broken in v0.9.1 by
[@&#8203;shamoon](https://github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3579](https://github.com/gethomepage/homepage/pull/3579)
- Fix: omada widget broken in v0.9.1 by
[@&#8203;shamoon](https://github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3587](https://github.com/gethomepage/homepage/pull/3587)
- Fix/handle null id in json rpc responses and cpu load representation
for openwrt widget by [@&#8203;LiranV](https://github.com/LiranV) in
[https://github.com/gethomepage/homepage/pull/3576](https://github.com/gethomepage/homepage/pull/3576)
- Fix: wg-easy threshold not properly computed by
[@&#8203;ConnerWithAnE](https://github.com/ConnerWithAnE) in
[https://github.com/gethomepage/homepage/pull/3574](https://github.com/gethomepage/homepage/pull/3574)
- Enhancement: support multiple instance annotation for Kubernetes
Automatic Service Discovery by
[@&#8203;aldycool](https://github.com/aldycool) in
[https://github.com/gethomepage/homepage/pull/3590](https://github.com/gethomepage/homepage/pull/3590)
- Fix: coinmarketcap widget dropdown not clickable by
[@&#8203;henry40408](https://github.com/henry40408) in
[https://github.com/gethomepage/homepage/pull/3591](https://github.com/gethomepage/homepage/pull/3591)

#### New Contributors

- [@&#8203;LiranV](https://github.com/LiranV) made their first
contribution in
[https://github.com/gethomepage/homepage/pull/3576](https://github.com/gethomepage/homepage/pull/3576)
- [@&#8203;aldycool](https://github.com/aldycool) made their first
contribution in
[https://github.com/gethomepage/homepage/pull/3590](https://github.com/gethomepage/homepage/pull/3590)

**Full Changelog**:
gethomepage/homepage@v0.9.1...v0.9.2

###
[`v0.9.1`](https://github.com/gethomepage/homepage/releases/tag/v0.9.1)

[Compare
Source](https://github.com/gethomepage/homepage/compare/v0.8.13...v0.9.1)

#### What's Changed

*Note: version 0.9.0 contained a few issues and did not completely
resolve the security issue, it has been removed and all users are
recommended to upgrade to v0.9.1*

##### Security

- This version resolves security vulnerabilities discovered in some
integrations, see
GHSA-24m5-7vjx-9x37.
Thanks to kachakil-av for reporting.

##### Other Changes

- Fix: calendar integration broken in v0.9.0 by
[@&#8203;shamoon](https://github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3565](https://github.com/gethomepage/homepage/pull/3565)
- Fix: glances cpu metric broken in v0.9.0 by
[@&#8203;shamoon](https://github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3566](https://github.com/gethomepage/homepage/pull/3566)
- Fix: handle ghostfolio v2.79.0 breaking API changes by
[@&#8203;shamoon](https://github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3471](https://github.com/gethomepage/homepage/pull/3471)
- Fix: allow exclamation to open quicklaunch by
[@&#8203;jesusmlopezf](https://github.com/jesusmlopezf) in
[https://github.com/gethomepage/homepage/pull/3475](https://github.com/gethomepage/homepage/pull/3475)
- Feature: Wg-Easy Widget by
[@&#8203;ConnerWithAnE](https://github.com/ConnerWithAnE) and
[@&#8203;shamoon](https://github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3476](https://github.com/gethomepage/homepage/pull/3476)
- Change icon in the longhorn widget to use the same as resources by
[@&#8203;nick-disiere](https://github.com/nick-disiere) in
[https://github.com/gethomepage/homepage/pull/3509](https://github.com/gethomepage/homepage/pull/3509)
- Feature: SWAG dashboard widget by
[@&#8203;quietsy](https://github.com/quietsy) and
[@&#8203;shamoon](https://github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3523](https://github.com/gethomepage/homepage/pull/3523)
- Chore(deps): Bump crowdin/github-action from 1 to 2 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/gethomepage/homepage/pull/3537](https://github.com/gethomepage/homepage/pull/3537)
- Fix: remove comma in Caddy and EVCC widgets by
[@&#8203;grimsi](https://github.com/grimsi) in
[https://github.com/gethomepage/homepage/pull/3551](https://github.com/gethomepage/homepage/pull/3551)
- Enhancement: separate Internet search settings for quicklaunch by
[@&#8203;vycdev](https://github.com/vycdev) and
[@&#8203;shamoon](https://github.com/shamoon) in
[https://github.com/gethomepage/homepage/pull/3541](https://github.com/gethomepage/homepage/pull/3541)
- Chore(deps-dev): Bump eslint-plugin-react from 7.34.1 to 7.34.2 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/gethomepage/homepage/pull/3554](https://github.com/gethomepage/homepage/pull/3554)
- Chore(deps-dev): Bump eslint-plugin-react-hooks from 4.6.0 to 4.6.2 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/gethomepage/homepage/pull/3555](https://github.com/gethomepage/homepage/pull/3555)

#### New Contributors

- [@&#8203;jesusmlopezf](https://github.com/jesusmlopezf) made their
first contribution in
[https://github.com/gethomepage/homepage/pull/3475](https://github.com/gethomepage/homepage/pull/3475)
- [@&#8203;ConnerWithAnE](https://github.com/ConnerWithAnE) made their
first contribution in
[https://github.com/gethomepage/homepage/pull/3476](https://github.com/gethomepage/homepage/pull/3476)
- [@&#8203;nick-disiere](https://github.com/nick-disiere) made their
first contribution in
[https://github.com/gethomepage/homepage/pull/3509](https://github.com/gethomepage/homepage/pull/3509)
- [@&#8203;quietsy](https://github.com/quietsy) made their first
contribution in
[https://github.com/gethomepage/homepage/pull/3523](https://github.com/gethomepage/homepage/pull/3523)
- [@&#8203;vycdev](https://github.com/vycdev) made their first
contribution in
[https://github.com/gethomepage/homepage/pull/3541](https://github.com/gethomepage/homepage/pull/3541)

**Full Changelog**:
gethomepage/homepage@v0.8.13...v0.9.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5NC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL21pbm9yIl19-->
Copy link
Contributor

github-actions bot commented Jul 6, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants